2013-03-05 12:08:10

by Éric Piel

[permalink] [raw]
Subject: Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

On 26/02/13 18:19, Takashi Iwai wrote:
> The DriveGuard chips on the new HP laptops are with a new PnP ID
> "HPQ6007". It should be compatible with older chips.
>
> Signed-off-by: Takashi Iwai <[email protected]>
Hi,
Sorry for the delay. The driver is able to detect the actual type of
accelerometer behind, so indeed it should work fine.

Thanks for the patch, here is my:
Acked-by: ?ric Piel <[email protected]>

Matthew, could you pick this patch into your tree?
Cheers,
?ric
>
> ---
> drivers/platform/x86/hp_accel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/hp_accel.c b/drivers/platform/x86/hp_accel.c
> index e64a7a8..b6c4305 100644
> --- a/drivers/platform/x86/hp_accel.c
> +++ b/drivers/platform/x86/hp_accel.c
> @@ -77,6 +77,7 @@ static inline void delayed_sysfs_set(struct led_classdev *led_cdev,
> static struct acpi_device_id lis3lv02d_device_ids[] = {
> {"HPQ0004", 0}, /* HP Mobile Data Protection System PNP */
> {"HPQ6000", 0}, /* HP Mobile Data Protection System PNP */
> + {"HPQ6007", 0}, /* HP Mobile Data Protection System PNP */
> {"", 0},
> };
> MODULE_DEVICE_TABLE(acpi, lis3lv02d_device_ids);
>


2013-03-05 15:43:13

by Matthew Garrett

[permalink] [raw]
Subject: Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

On Tue, 2013-03-05 at 12:49 +0100, Éric Piel wrote:
> On 26/02/13 18:19, Takashi Iwai wrote:
> > The DriveGuard chips on the new HP laptops are with a new PnP ID
> > "HPQ6007". It should be compatible with older chips.
> >
> > Signed-off-by: Takashi Iwai <[email protected]>
> Hi,
> Sorry for the delay. The driver is able to detect the actual type of
> accelerometer behind, so indeed it should work fine.
>
> Thanks for the patch, here is my:
> Acked-by: Éric Piel <[email protected]>
>
> Matthew, could you pick this patch into your tree?

Will do.

--
Matthew Garrett | [email protected]
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?

2013-03-05 15:45:34

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

At Tue, 5 Mar 2013 15:42:58 +0000,
Matthew Garrett wrote:
>
> On Tue, 2013-03-05 at 12:49 +0100, Éric Piel wrote:
> > On 26/02/13 18:19, Takashi Iwai wrote:
> > > The DriveGuard chips on the new HP laptops are with a new PnP ID
> > > "HPQ6007". It should be compatible with older chips.
> > >
> > > Signed-off-by: Takashi Iwai <[email protected]>
> > Hi,
> > Sorry for the delay. The driver is able to detect the actual type of
> > accelerometer behind, so indeed it should work fine.
> >
> > Thanks for the patch, here is my:
> > Acked-by: Éric Piel <[email protected]>
> >
> > Matthew, could you pick this patch into your tree?
>
> Will do.

Thanks!


Takashi

2013-03-08 22:59:59

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

On Tue, Mar 5, 2013 at 8:45 AM, Takashi Iwai <[email protected]> wrote:
> At Tue, 5 Mar 2013 15:42:58 +0000,
> Matthew Garrett wrote:
>>
>> On Tue, 2013-03-05 at 12:49 +0100, ?ric Piel wrote:
>> > On 26/02/13 18:19, Takashi Iwai wrote:
>> > > The DriveGuard chips on the new HP laptops are with a new PnP ID
>> > > "HPQ6007". It should be compatible with older chips.
>> > >
>> > > Signed-off-by: Takashi Iwai <[email protected]>
>> > Hi,
>> > Sorry for the delay. The driver is able to detect the actual type of
>> > accelerometer behind, so indeed it should work fine.
>> >
>> > Thanks for the patch, here is my:
>> > Acked-by: ?ric Piel <[email protected]>
>> >
>> > Matthew, could you pick this patch into your tree?
>>
>> Will do.
>
> Thanks!
>
>
> Takashi

Takashi,

Should this be tagged for stables releases? This patch went into suse
git and just checking to see if it should go into stable releases.

Thanks,
-- Shuah

2013-03-09 12:00:11

by Éric Piel

[permalink] [raw]
Subject: Re: [PATCH] hp_accel: Add a new PnP ID HPQ6007 for new HP laptops

On 08-03-13 23:59, Shuah Khan wrote:
:
> Should this be tagged for stables releases? This patch went into suse
> git and just checking to see if it should go into stable releases.
Hello,
This patch will make the module automatically load on some new HP
laptops. So although it's not fixing a bug, it will extend hardware
support (a very little bit), which can be considered material for stable
trees, indeed.

Cheers,
Éric