2020-02-08 09:04:44

by Kees Cook

Subject: [PATCH] ARM: Remove unused .fixup section in boot stub

The boot stub does not emit a .fixup section at all anymore, so remove
it.

Suggested-by: Nick Desaulniers <[email protected]>
Link: https://lore.kernel.org/lkml/CAKwvOdnRhx=SgtcUCyX2ZOGATM8OzG6hSOY9wGQZcwtp+P5WBQ@mail.gmail.com
Signed-off-by: Kees Cook <[email protected]>
---
arch/arm/boot/compressed/vmlinux.lds.S | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/compressed/vmlinux.lds.S b/arch/arm/boot/compressed/vmlinux.lds.S
index fc7ed03d8b93..b247f399de71 100644
--- a/arch/arm/boot/compressed/vmlinux.lds.S
+++ b/arch/arm/boot/compressed/vmlinux.lds.S
@@ -36,7 +36,6 @@ SECTIONS
*(.start)
*(.text)
*(.text.*)
- *(.fixup)
*(.gnu.warning)
*(.glue_7t)
*(.glue_7)
--
2.20.1


--
Kees Cook

2020-02-08 09:15:42

by Ard Biesheuvel

Subject: Re: [PATCH] ARM: Remove unused .fixup section in boot stub

On Sat, 8 Feb 2020 at 09:04, Kees Cook <[email protected]> wrote:
>
> The boot stub does not emit a .fixup section at all anymore, so remove
> it.
>
> Suggested-by: Nick Desaulniers <[email protected]>
> Link: https://lore.kernel.org/lkml/CAKwvOdnRhx=SgtcUCyX2ZOGATM8OzG6hSOY9wGQZcwtp+P5WBQ@mail.gmail.com
> Signed-off-by: Kees Cook <[email protected]>

Reviewed-by: Ard Biesheuvel <[email protected]>

I'd assume these are uncontroversial enough to go straight into the
patch system.

> ---
> arch/arm/boot/compressed/vmlinux.lds.S | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/compressed/vmlinux.lds.S b/arch/arm/boot/compressed/vmlinux.lds.S
> index fc7ed03d8b93..b247f399de71 100644
> --- a/arch/arm/boot/compressed/vmlinux.lds.S
> +++ b/arch/arm/boot/compressed/vmlinux.lds.S
> @@ -36,7 +36,6 @@ SECTIONS
> *(.start)
> *(.text)
> *(.text.*)
> - *(.fixup)
> *(.gnu.warning)
> *(.glue_7t)
> *(.glue_7)
> --
> 2.20.1
>
>
> --
> Kees Cook

2020-02-08 10:07:30

by Nick Desaulniers

Subject: Re: [PATCH] ARM: Remove unused .fixup section in boot stub

On Sat, Feb 8, 2020 at 10:04 AM Kees Cook <[email protected]> wrote:
>
> The boot stub does not emit a .fixup section at all anymore, so remove
> it.
>
> Suggested-by: Nick Desaulniers <[email protected]>
> Link: https://lore.kernel.org/lkml/CAKwvOdnRhx=SgtcUCyX2ZOGATM8OzG6hSOY9wGQZcwtp+P5WBQ@mail.gmail.com
> Signed-off-by: Kees Cook <[email protected]>

thanks for the patch!
Reviewed-by: Nick Desaulniers <[email protected]>

> ---
> arch/arm/boot/compressed/vmlinux.lds.S | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/compressed/vmlinux.lds.S b/arch/arm/boot/compressed/vmlinux.lds.S
> index fc7ed03d8b93..b247f399de71 100644
> --- a/arch/arm/boot/compressed/vmlinux.lds.S
> +++ b/arch/arm/boot/compressed/vmlinux.lds.S
> @@ -36,7 +36,6 @@ SECTIONS
> *(.start)
> *(.text)
> *(.text.*)
> - *(.fixup)
> *(.gnu.warning)
> *(.glue_7t)
> *(.glue_7)
> --
> 2.20.1
>
>
> --
> Kees Cook



--
Thanks,
~Nick Desaulniers