2019-06-19 18:20:26

by Nick Desaulniers

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: add CLANG/LLVM BUILD SUPPORT info

Add keyword support so that our mailing list gets cc'ed for clang/llvm
patches. We're pretty active on our mailing list so far as code review.
There are numerous Googlers like myself that are paid to support
building the Linux kernel with Clang and LLVM.

Signed-off-by: Nick Desaulniers <[email protected]>
---
Thanks for Joe Perches for help on the syntax for the case insensitive
syntax.

MAINTAINERS | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ef58d9a881ee..fa798cc48e34 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3940,6 +3940,14 @@ M: Miguel Ojeda <[email protected]>
S: Maintained
F: .clang-format

+CLANG/LLVM BUILD SUPPORT
+L: [email protected]
+W: https://clangbuiltlinux.github.io/
+B: https://github.com/ClangBuiltLinux/linux/issues
+C: irc://chat.freenode.net/clangbuiltlinux
+S: Supported
+K: \b(?i:clang|llvm)\b
+
CLEANCACHE API
M: Konrad Rzeszutek Wilk <[email protected]>
L: [email protected]
--
2.22.0.410.gd8fdbe21b5-goog


2019-06-19 18:28:06

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add CLANG/LLVM BUILD SUPPORT info

On Wed, 2019-06-19 at 11:18 -0700, Nick Desaulniers wrote:
> Add keyword support so that our mailing list gets cc'ed for clang/llvm
> patches.

You'd also possibly get cc'd on patches that merely mention
clang or llvm like any change to clang-format. It could be
many files that aren't interesting.

$ git grep -i -w -P --name-only '(?i:clang|llvm)' | wc -l
134

> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -3940,6 +3940,14 @@ M: Miguel Ojeda <[email protected]>
> S: Maintained
> F: .clang-format
>
> +CLANG/LLVM BUILD SUPPORT
> +L: [email protected]
> +W: https://clangbuiltlinux.github.io/
> +B: https://github.com/ClangBuiltLinux/linux/issues
> +C: irc://chat.freenode.net/clangbuiltlinux
> +S: Supported
> +K: \b(?i:clang|llvm)\b
> +

Please use a single tab after each : like below

CLANG/LLVM BUILD SUPPORT
L: [email protected]
W: https://clangbuiltlinux.github.io/
B: https://github.com/ClangBuiltLinux/linux/issues
C: irc://chat.freenode.net/clangbuiltlinux
S: Supported
K: \b(?i:clang|llvm)\b


2019-06-19 19:19:16

by Louis Taylor

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add CLANG/LLVM BUILD SUPPORT info

On Wed, Jun 19, 2019 at 11:18:44AM -0700, 'Nick Desaulniers' via Clang Built Linux wrote:
> Add keyword support so that our mailing list gets cc'ed for clang/llvm
> patches. We're pretty active on our mailing list so far as code review.
> There are numerous Googlers like myself that are paid to support
> building the Linux kernel with Clang and LLVM.
>
> Signed-off-by: Nick Desaulniers <[email protected]>
> ---
> Thanks for Joe Perches for help on the syntax for the case insensitive
> syntax.
>
> MAINTAINERS | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ef58d9a881ee..fa798cc48e34 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3940,6 +3940,14 @@ M: Miguel Ojeda <[email protected]>
> S: Maintained
> F: .clang-format
>
> +CLANG/LLVM BUILD SUPPORT
> +L: [email protected]

I think this should have "(moderated for non-subscribers)" added.

Cheers,
Louis

2019-06-19 19:51:00

by Nick Desaulniers

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add CLANG/LLVM BUILD SUPPORT info

On Wed, Jun 19, 2019 at 12:17 PM Louis Taylor <[email protected]> wrote:
>
> On Wed, Jun 19, 2019 at 11:18:44AM -0700, 'Nick Desaulniers' via Clang Built Linux wrote:
> > Add keyword support so that our mailing list gets cc'ed for clang/llvm
> > patches. We're pretty active on our mailing list so far as code review.
> > There are numerous Googlers like myself that are paid to support
> > building the Linux kernel with Clang and LLVM.
> > +CLANG/LLVM BUILD SUPPORT
> > +L: [email protected]
>
> I think this should have "(moderated for non-subscribers)" added.

The current setting is "anyone from the web [may post]" as otherwise
the various CI services reporting there have issues. There is a basic
spam filter that emails me every so often. Not sure if that's quite
considered "moderated for non-subscribers" or if I'm just being overly
pedantic? (Point being that I don't think you have to subscribe to
post)
--
Thanks,
~Nick Desaulniers

2019-06-19 19:54:50

by Nick Desaulniers

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: add CLANG/LLVM BUILD SUPPORT info

On Wed, Jun 19, 2019 at 11:27 AM Joe Perches <[email protected]> wrote:
>
> On Wed, 2019-06-19 at 11:18 -0700, Nick Desaulniers wrote:
> > Add keyword support so that our mailing list gets cc'ed for clang/llvm
> > patches.
>
> You'd also possibly get cc'd on patches that merely mention
> clang or llvm like any change to clang-format. It could be
> many files that aren't interesting.
>
> $ git grep -i -w -P --name-only '(?i:clang|llvm)' | wc -l
> 134

That's very much intentional. We currently get ~11 emails a day from
various CI services (KernelCI, 0day bot), patch authors, etc. so I
don't think this adds too much more and it's mostly signal (signal to
noise). Maybe the bpf stuff would be less relevant, but I don't think
it hurts.

> Please use a single tab after each : like below

gah! My editor does flag this
(https://github.com/nickdesaulniers/dotfiles/blob/37359525f5a403b4ed2d3f9d1bbbee2da8ec8115/.vimrc#L35-L41)
whether or not I notice is sadly another story. Good catch, v2
inbound.
--
Thanks,
~Nick Desaulniers

2019-06-20 00:19:32

by Nick Desaulniers

[permalink] [raw]
Subject: [PATCH v2] MAINTAINERS: add CLANG/LLVM BUILD SUPPORT info

Add keyword support so that our mailing list gets cc'ed for clang/llvm
patches. We're pretty active on our mailing list so far as code review.
There are numerous Googlers like myself that are paid to support
building the Linux kernel with Clang and LLVM.

Signed-off-by: Nick Desaulniers <[email protected]>
---
Changes V1 -> V2:
- tabs vs spaces as per Joe Perches

MAINTAINERS | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index ef58d9a881ee..f92432452f46 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3940,6 +3940,14 @@ M: Miguel Ojeda <[email protected]>
S: Maintained
F: .clang-format

+CLANG/LLVM BUILD SUPPORT
+L: [email protected]
+W: https://clangbuiltlinux.github.io/
+B: https://github.com/ClangBuiltLinux/linux/issues
+C: irc://chat.freenode.net/clangbuiltlinux
+S: Supported
+K: \b(?i:clang|llvm)\b
+
CLEANCACHE API
M: Konrad Rzeszutek Wilk <[email protected]>
L: [email protected]
--
2.22.0.410.gd8fdbe21b5-goog

2019-06-20 02:56:28

by Nathan Chancellor

[permalink] [raw]
Subject: Re: [PATCH v2] MAINTAINERS: add CLANG/LLVM BUILD SUPPORT info

On Wed, Jun 19, 2019 at 05:19:07PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote:
> Add keyword support so that our mailing list gets cc'ed for clang/llvm
> patches. We're pretty active on our mailing list so far as code review.
> There are numerous Googlers like myself that are paid to support
> building the Linux kernel with Clang and LLVM.
>
> Signed-off-by: Nick Desaulniers <[email protected]>

FWIW, if it is not too late:

Reviewed-by: Nathan Chancellor <[email protected]>

> ---
> Changes V1 -> V2:
> - tabs vs spaces as per Joe Perches
>
> MAINTAINERS | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ef58d9a881ee..f92432452f46 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3940,6 +3940,14 @@ M: Miguel Ojeda <[email protected]>
> S: Maintained
> F: .clang-format
>
> +CLANG/LLVM BUILD SUPPORT
> +L: [email protected]
> +W: https://clangbuiltlinux.github.io/
> +B: https://github.com/ClangBuiltLinux/linux/issues
> +C: irc://chat.freenode.net/clangbuiltlinux
> +S: Supported
> +K: \b(?i:clang|llvm)\b
> +
> CLEANCACHE API
> M: Konrad Rzeszutek Wilk <[email protected]>
> L: [email protected]
> --
> 2.22.0.410.gd8fdbe21b5-goog
>