2020-04-14 13:22:41

by Pavel Shilovsky

Subject: Re: [PATCH] cifs: improve read performance for page size 64KB & cache=strict & vers=2.1+

Looks good, thanks!

Reviewed-by: Pavel Shilovsky <[email protected]>

--
Best regards,
Pavel Shilovsky

вс, 12 апр. 2020 г. в 19:23, Jones Syue <[email protected]>:
>
> Hello Pavel
>
> Thanks for kindly reviewing!
> Please find the attached v2.patch.
>
> --
> Regards,
> Jones Syue | 薛懷宗
> QNAP Systems, Inc.
>
>
> On Sat, Apr 11, 2020 at 2:25 AM Pavel Shilovsky <[email protected]> wrote:
> >
> > Hi Jones,
> >
> > Thanks for the patch!
> >
> > It will work although it is probably a little bit cleaner to
> > initialize server->max_read to server->maxBuf for SMB1 and use the
> > server->max_read in the readpages condition check instead.
> >
> > @Others, thoughts?
> >
> > --
> > Best regards,
> > Pavel Shilovsky

2020-04-14 13:50:13

by Steve French

Subject: Re: [PATCH] cifs: improve read performance for page size 64KB & cache=strict & vers=2.1+

merged into cifs-2.6.git for-next pending testing

On Mon, Apr 13, 2020 at 11:39 AM Pavel Shilovsky via samba-technical
<[email protected]> wrote:
>
> Looks good, thanks!
>
> Reviewed-by: Pavel Shilovsky <[email protected]>
>
> --
> Best regards,
> Pavel Shilovsky
>
> вс, 12 апр. 2020 г. в 19:23, Jones Syue <[email protected]>:
> >
> > Hello Pavel
> >
> > Thanks for kindly reviewing!
> > Please find the attached v2.patch.
> >
> > --
> > Regards,
> > Jones Syue | 薛懷宗
> > QNAP Systems, Inc.
> >
> >
> > On Sat, Apr 11, 2020 at 2:25 AM Pavel Shilovsky <[email protected]> wrote:
> > >
> > > Hi Jones,
> > >
> > > Thanks for the patch!
> > >
> > > It will work although it is probably a little bit cleaner to
> > > initialize server->max_read to server->maxBuf for SMB1 and use the
> > > server->max_read in the readpages condition check instead.
> > >
> > > @Others, thoughts?
> > >
> > > --
> > > Best regards,
> > > Pavel Shilovsky
>


--
Thanks,

Steve