2021-10-29 21:58:51

by Charles Mirabile

[permalink] [raw]
Subject: [PATCH 0/5] Raspberry Pi Sense HAT driver

This patch series adds a set of drivers for operating the Sense HAT
peripheral device. This board is an add on for the Raspberry Pi that is
designed to connect using the GPIO connector via I2C.

It features:
- a joystick
- an 8x8 RGB LED matrix display
- a whole bunch of environmental sensors with their own drivers
(those are already in upstream Linux)

This is a refactor of the work of Serge Schneider, the author of a
version of this driver that is currently in the Raspberry Pi downstream
kernel. We modified his code to make it suitable for upstream Linux.

A couple of tests are available for the driver in this repo:
https://github.com/underground-software/sensehat/tree/master/tests
- color_test displays various solid colors on the LED panel
- framebuffer_test diplays a single lit cell that is
controllable via the arrow keys or the joystick

For more information about the Sense HAT, visit:
https://www.raspberrypi.org/products/sense-hat/

Changes since v2:
- We included a device tree binding in yaml form
- Switched to regmap for all i2c communications
- Fixed a few places where we had the old rpisense
name that we missed when renaming for v2

Signed-off-by: Charles Mirabile <[email protected]>
Signed-off-by: Mwesigwa Guma <[email protected]>
Signed-off-by: Joel Savitz <[email protected]>

Charles Mirabile (5):
drivers/mfd: sensehat: Raspberry Pi Sense HAT core driver
drivers/input/joystick: sensehat: Raspberry Pi Sense HAT joystick
driver
drivers/auxdisplay: senshat: Raspberry Pi Sense HAT display driver
Documentation: bindings/mfd: sensehat: Raspberry Pi Sense HAT device
tree binding
MAINTAINERS: Add sensehat driver authors to MAINTAINERS

.../bindings/mfd/raspberrypi,sensehat.yaml | 50 ++++
MAINTAINERS | 11 +
drivers/auxdisplay/Kconfig | 7 +
drivers/auxdisplay/Makefile | 1 +
drivers/auxdisplay/sensehat-display.c | 258 ++++++++++++++++++
drivers/input/joystick/Kconfig | 8 +
drivers/input/joystick/Makefile | 1 +
drivers/input/joystick/sensehat-joystick.c | 135 +++++++++
drivers/mfd/Kconfig | 8 +
drivers/mfd/Makefile | 1 +
drivers/mfd/sensehat-core.c | 164 +++++++++++
include/linux/mfd/sensehat.h | 64 +++++
12 files changed, 708 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/raspberrypi,sensehat.yaml
create mode 100644 drivers/auxdisplay/sensehat-display.c
create mode 100644 drivers/input/joystick/sensehat-joystick.c
create mode 100644 drivers/mfd/sensehat-core.c
create mode 100644 include/linux/mfd/sensehat.h

--
2.31.1


2021-10-31 16:40:12

by Miguel Ojeda

[permalink] [raw]
Subject: Re: [PATCH 0/5] Raspberry Pi Sense HAT driver

On Fri, Oct 29, 2021 at 11:58 PM Charles Mirabile <[email protected]> wrote:
>
> Signed-off-by: Charles Mirabile <[email protected]>
> Signed-off-by: Mwesigwa Guma <[email protected]>
> Signed-off-by: Joel Savitz <[email protected]>

Please note that you need to write `Co-developed-by: ...` (see
`Documentation/process/submitting-patches.rst`); otherwise, it looks
as if this was sent through several layers.

Cheers,
Miguel

2021-11-01 14:22:30

by Joel Savitz

[permalink] [raw]
Subject: Re: [PATCH 0/5] Raspberry Pi Sense HAT driver

Thanks for the suggestion, we weren't sure what the right "Xxx-by:"
was for this circumstance so we will use this in subsequent patchsets.

Best,
Joel Savitz

Best,
Joel Savitz


On Sun, Oct 31, 2021 at 12:39 PM Miguel Ojeda
<[email protected]> wrote:
>
> On Fri, Oct 29, 2021 at 11:58 PM Charles Mirabile <[email protected]> wrote:
> >
> > Signed-off-by: Charles Mirabile <[email protected]>
> > Signed-off-by: Mwesigwa Guma <[email protected]>
> > Signed-off-by: Joel Savitz <[email protected]>
>
> Please note that you need to write `Co-developed-by: ...` (see
> `Documentation/process/submitting-patches.rst`); otherwise, it looks
> as if this was sent through several layers.
>
> Cheers,
> Miguel
>

2021-11-20 10:55:52

by Stefan Wahren

[permalink] [raw]
Subject: Re: [PATCH 0/5] Raspberry Pi Sense HAT driver

Hi,

Am 29.10.21 um 23:55 schrieb Charles Mirabile:
> This patch series adds a set of drivers for operating the Sense HAT
> peripheral device. This board is an add on for the Raspberry Pi that is
> designed to connect using the GPIO connector via I2C.
>
> It features:
> - a joystick
> - an 8x8 RGB LED matrix display
> - a whole bunch of environmental sensors with their own drivers
> (those are already in upstream Linux)
>
> This is a refactor of the work of Serge Schneider, the author of a
> version of this driver that is currently in the Raspberry Pi downstream
> kernel. We modified his code to make it suitable for upstream Linux.
>
> A couple of tests are available for the driver in this repo:
> https://github.com/underground-software/sensehat/tree/master/tests
> - color_test displays various solid colors on the LED panel
> - framebuffer_test diplays a single lit cell that is
> controllable via the arrow keys or the joystick
>
> For more information about the Sense HAT, visit:
> https://www.raspberrypi.org/products/sense-hat/
>
> Changes since v2:
> - We included a device tree binding in yaml form
> - Switched to regmap for all i2c communications
> - Fixed a few places where we had the old rpisense
> name that we missed when renaming for v2

since this is V2 of the patch series, please mark this properly in all
subjects:

[PATCH V2 0/5] ...

Otherwise this is a nightmare for reviewers and maintainers.

Best regards