2020-12-17 12:33:31

by yanteng si

Subject: [PATCH] cma_heap: fix implicit function declaration

From: siyanteng <[email protected]>

When building cma_heap the following error shows up:

drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
195 | vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
| ^~~~
| kmap

Use this include: linux-next/include/linux/vmalloc.h

Signed-off-by: siyanteng <[email protected]>
---
drivers/dma-buf/heaps/cma_heap.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma-buf/heaps/cma_heap.c b/drivers/dma-buf/heaps/cma_heap.c
index 5e7c3436310c..3c4e34301172 100644
--- a/drivers/dma-buf/heaps/cma_heap.c
+++ b/drivers/dma-buf/heaps/cma_heap.c
@@ -20,6 +20,7 @@
#include <linux/module.h>
#include <linux/scatterlist.h>
#include <linux/slab.h>
+#include <linux/vmalloc.h>


struct cma_heap {
--
2.27.0

2020-12-17 19:43:00

by John Stultz

Subject: Re: [PATCH] cma_heap: fix implicit function declaration

On Thu, Dec 17, 2020 at 4:31 AM <[email protected]> wrote:
>
> From: siyanteng <[email protected]>
>
> When building cma_heap the following error shows up:
>
> drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
> 195 | vaddr = vmap(buffer->pages, buffer->pagecount, VM_MAP, PAGE_KERNEL);
> | ^~~~
> | kmap
>
> Use this include: linux-next/include/linux/vmalloc.h
>
> Signed-off-by: siyanteng <[email protected]>

Thanks for submitting this! My apologies for the trouble!

We already have a similar patch queued here:
https://cgit.freedesktop.org/drm/drm-misc/commit/?h=drm-misc-next-fixes&id=8075c3005e4b1efa12dbbf6e84bc412a713de92c
so hopefully that will land upstream soon.

thanks again!
-john