2014-12-21 10:56:26

by Geert Uytterhoeven

Subject: [PATCH] ceph: Use %zu to format size_t in ceph_fill_inline_data()

On 32-bit, where size_t is unsigned int:

fs/ceph/addr.c: In function ‘ceph_fill_inline_data’:
fs/ceph/addr.c:1419: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 10 has type ‘size_t’

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
fs/ceph/addr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index f5013d92a7e6b73d..c81c0e004588b9e2 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1416,7 +1416,7 @@ void ceph_fill_inline_data(struct inode *inode, struct page *locked_page,
}
}

- dout("fill_inline_data %p %llx.%llx len %lu locked_page %p\n",
+ dout("fill_inline_data %p %llx.%llx len %zu locked_page %p\n",
inode, ceph_vinop(inode), len, locked_page);

if (len > 0) {
--
1.9.1

2014-12-21 11:10:22

by Ilya Dryomov

Subject: Re: [PATCH] ceph: Use %zu to format size_t in ceph_fill_inline_data()

On Sun, Dec 21, 2014 at 1:56 PM, Geert Uytterhoeven
<[email protected]> wrote:
> On 32-bit, where size_t is unsigned int:
>
> fs/ceph/addr.c: In function ‘ceph_fill_inline_data’:
> fs/ceph/addr.c:1419: warning: format ‘%lu’ expects type ‘long unsigned int’, but argument 10 has type ‘size_t’
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> fs/ceph/addr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index f5013d92a7e6b73d..c81c0e004588b9e2 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1416,7 +1416,7 @@ void ceph_fill_inline_data(struct inode *inode, struct page *locked_page,
> }
> }
>
> - dout("fill_inline_data %p %llx.%llx len %lu locked_page %p\n",
> + dout("fill_inline_data %p %llx.%llx len %zu locked_page %p\n",
> inode, ceph_vinop(inode), len, locked_page);

Sorry, it's been reported by kbuild robot a couple days ago and is
already fixed along with another warning.

Thanks,

Ilya