2024-01-09 22:03:18

by Sean Christopherson

Subject: [PATCH] KVM: selftests: Delete superfluous, unused "stage" variable in AMX test

Delete the AMX's tests "stage" counter, as the counter is no longer used,
which makes clang unhappy:

x86_64/amx_test.c:224:6: error: variable 'stage' set but not used
int stage, ret;
^
1 error generated.

Note, "stage" was never really used, it just happened to be dumped out by
a (failed) assertion on run->exit_reason, i.e. the AMX test has no concept
of stages, the code was likely copy+pasted from a different test.

Fixes: c96f57b08012 ("KVM: selftests: Make vCPU exit reason test assertion common")
Signed-off-by: Sean Christopherson <[email protected]>
---
tools/testing/selftests/kvm/x86_64/amx_test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/kvm/x86_64/amx_test.c b/tools/testing/selftests/kvm/x86_64/amx_test.c
index 11329e5ff945..309ee5c72b46 100644
--- a/tools/testing/selftests/kvm/x86_64/amx_test.c
+++ b/tools/testing/selftests/kvm/x86_64/amx_test.c
@@ -221,7 +221,7 @@ int main(int argc, char *argv[])
vm_vaddr_t amx_cfg, tiledata, xstate;
struct ucall uc;
u32 amx_offset;
- int stage, ret;
+ int ret;

/*
* Note, all off-by-default features must be enabled before anything
@@ -263,7 +263,7 @@ int main(int argc, char *argv[])
memset(addr_gva2hva(vm, xstate), 0, PAGE_SIZE * DIV_ROUND_UP(XSAVE_SIZE, PAGE_SIZE));
vcpu_args_set(vcpu, 3, amx_cfg, tiledata, xstate);

- for (stage = 1; ; stage++) {
+ for (;;) {
vcpu_run(vcpu);
TEST_ASSERT_KVM_EXIT_REASON(vcpu, KVM_EXIT_IO);


base-commit: 1c6d984f523f67ecfad1083bb04c55d91977bb15
--
2.43.0.472.g3155946c3a-goog

2024-01-09 22:34:03

by Jim Mattson

Subject: Re: [PATCH] KVM: selftests: Delete superfluous, unused "stage" variable in AMX test

On Tue, Jan 9, 2024 at 2:03 PM Sean Christopherson <[email protected]> wrote:
>
> Delete the AMX's tests "stage" counter, as the counter is no longer used,
> which makes clang unhappy:
>
> x86_64/amx_test.c:224:6: error: variable 'stage' set but not used
> int stage, ret;
> ^
> 1 error generated.
>
> Note, "stage" was never really used, it just happened to be dumped out by
> a (failed) assertion on run->exit_reason, i.e. the AMX test has no concept
> of stages, the code was likely copy+pasted from a different test.
>
> Fixes: c96f57b08012 ("KVM: selftests: Make vCPU exit reason test assertion common")
> Signed-off-by: Sean Christopherson <[email protected]>

Reviewed-by: Jim Mattson <[email protected]>

2024-01-31 01:01:17

by Sean Christopherson

Subject: Re: [PATCH] KVM: selftests: Delete superfluous, unused "stage" variable in AMX test

On Tue, 09 Jan 2024 14:03:02 -0800, Sean Christopherson wrote:
> Delete the AMX's tests "stage" counter, as the counter is no longer used,
> which makes clang unhappy:
>
> x86_64/amx_test.c:224:6: error: variable 'stage' set but not used
> int stage, ret;
> ^
> 1 error generated.
>
> [...]

Applied to kvm-x86 selftests, thanks!

[1/1] KVM: selftests: Delete superfluous, unused "stage" variable in AMX test
https://github.com/kvm-x86/linux/commit/46fee9e38995

--
https://github.com/kvm-x86/linux/tree/next