2019-11-22 20:18:52

by Sean Christopherson

Subject: [PATCH] KVM: x86: Remove a spurious export of a static function

A recent change inadvertantly exported a static function, which results
in modpost throwing a warning. Fix it.

Fixes: cbbaa2727aa3 ("KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES")
Signed-off-by: Sean Christopherson <[email protected]>
---
arch/x86/kvm/x86.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index a256e09f321a..3e9ab2d1ea77 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -1329,7 +1329,6 @@ static u64 kvm_get_arch_capabilities(void)

return data;
}
-EXPORT_SYMBOL_GPL(kvm_get_arch_capabilities);

static int kvm_get_msr_feature(struct kvm_msr_entry *msr)
{
--
2.24.0

2019-11-22 20:42:00

by Jim Mattson

Subject: Re: [PATCH] KVM: x86: Remove a spurious export of a static function

On Fri, Nov 22, 2019 at 12:15 PM Sean Christopherson
<[email protected]> wrote:
>
> A recent change inadvertantly exported a static function, which results
Nit: inadvertently
> in modpost throwing a warning. Fix it.
>
> Fixes: cbbaa2727aa3 ("KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES")
> Signed-off-by: Sean Christopherson <[email protected]>
Reviewed-by: Jim Mattson <[email protected]>

2019-11-23 10:32:53

by Paolo Bonzini

Subject: Re: [PATCH] KVM: x86: Remove a spurious export of a static function

On 22/11/19 21:15, Sean Christopherson wrote:
> A recent change inadvertantly exported a static function, which results
> in modpost throwing a warning. Fix it.
>
> Fixes: cbbaa2727aa3 ("KVM: x86: fix presentation of TSX feature in ARCH_CAPABILITIES")
> Signed-off-by: Sean Christopherson <[email protected]>
> ---
> arch/x86/kvm/x86.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index a256e09f321a..3e9ab2d1ea77 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -1329,7 +1329,6 @@ static u64 kvm_get_arch_capabilities(void)
>
> return data;
> }
> -EXPORT_SYMBOL_GPL(kvm_get_arch_capabilities);
>
> static int kvm_get_msr_feature(struct kvm_msr_entry *msr)
> {
>

Queued, thanks.

Paolo