2017-11-29 19:06:13

by Jim Mattson

[permalink] [raw]
Subject: Re: [PATCH] KVM: VMX: Cache IA32_DEBUGCTL in memory

An alternative is to give the L1 guest read permission for this MSR in
the MSR permission bitmaps. It's still going to be ~80 cycles, but
that's better than the cost of a VM-exit/VM-entry round-trip.

On Wed, Nov 29, 2017 at 10:20 AM, Andi Kleen <[email protected]> wrote:
> Wanpeng Li <[email protected]> writes:
>
>> From: Wanpeng Li <[email protected]>
>>
>> MSR_IA32_DEBUGCTLMSR is zeroed on VMEXIT, so it is saved/restored
>> each time during world switch. Jim from Google pointed out that
>> when running schbench in L2, vmx_vcpu_run will occupy 4% cpu time,
>> and the 25% of vmx_vcpu_run cpu time is occupied by get_debugctlmsr().
>> This patch caches the host IA32_DEBUGCTL MSR and saves/restores
>> the host IA32_DEBUGCTL msr when guest/host switches to avoid to
>> save/restore each time during world switch.
>
> FWIW i've seen this too on L2 profiles.
>
> But I haven't looked too closely, but I suspect you'll clobber global
> kernel debugger state this way.
>
> You would at least need some interface for KDB etc. to invalidate
> your cache.
>
> -Andi

From 1585425963838666160@xxx Wed Nov 29 18:27:02 +0000 2017
X-GM-THRID: 1585379526281584765
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread