2023-05-31 16:15:36

by Jim Mattson

[permalink] [raw]
Subject: Re: [PATCH] KVM: VMX: restore vmx_vmexit alignment

On Wed, May 31, 2023 at 8:59 AM Jon Kohler <[email protected]> wrote:
>
> Commit 8bd200d23ec4 ("KVM: VMX: Flatten __vmx_vcpu_run()") changed
> vmx_vmexit from SYM_FUNC_START to SYM_INNER_LABEL, accidentally
> removing 16 byte alignment as SYM_FUNC_START uses SYM_A_ALIGN and
> SYM_INNER_LABEL does not. Josh mentioned [1] this was unintentional.
>
> Fix by changing to SYM_INNER_LABEL_ALIGN instead.
>
> [1] https://lore.kernel.org/lkml/Y3adkSe%2FJ70PqUyt@p183
>
> Fixes: 8bd200d23ec4 ("KVM: VMX: Flatten __vmx_vcpu_run()")
> Signed-off-by: Jon Kohler <[email protected]>
> Suggested-by: Alexey Dobriyan <[email protected]>
> CC: Josh Poimboeuf <[email protected]>

Reviewed-by: Jim Mattson <[email protected]>