2014-11-15 11:27:36

by Dmitry Baryshkov

Subject: [PATCH] genirq: Add IRQ 0 to domain debug file

Currently irq_domain_mapping debugfs file dumps IRQ information starting
from IRQ 1. IRQ 0 is missing from that file. Add it to have the complete
picture of IRQ/domains mappings.

Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
---
kernel/irq/irqdomain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
index 6534ff6..0e0c7a8 100644
--- a/kernel/irq/irqdomain.c
+++ b/kernel/irq/irqdomain.c
@@ -585,7 +585,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
"chip name", (int)(2 * sizeof(void *) + 2), "chip data",
"active", "type", "domain");

- for (i = 1; i < nr_irqs; i++) {
+ for (i = 0; i < nr_irqs; i++) {
desc = irq_to_desc(i);
if (!desc)
continue;
--
2.1.1

2014-11-15 13:02:31

by Jiang Liu

Subject: Re: [PATCH] genirq: Add IRQ 0 to domain debug file

On 2014/11/15 19:27, Dmitry Eremin-Solenikov wrote:
> Currently irq_domain_mapping debugfs file dumps IRQ information starting
> from IRQ 1. IRQ 0 is missing from that file. Add it to have the complete
> picture of IRQ/domains mappings.
Hi Dmitry,
For most irqdomain interfaces, they treat irq0 as invalid
interrupt. But on x86, it's possible to use irq0 for timer. It causes
may confusion when enabling irqdomain for x86.
Regards!
Gerry

>
> Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
> ---
> kernel/irq/irqdomain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/irq/irqdomain.c b/kernel/irq/irqdomain.c
> index 6534ff6..0e0c7a8 100644
> --- a/kernel/irq/irqdomain.c
> +++ b/kernel/irq/irqdomain.c
> @@ -585,7 +585,7 @@ static int virq_debug_show(struct seq_file *m, void *private)
> "chip name", (int)(2 * sizeof(void *) + 2), "chip data",
> "active", "type", "domain");
>
> - for (i = 1; i < nr_irqs; i++) {
> + for (i = 0; i < nr_irqs; i++) {
> desc = irq_to_desc(i);
> if (!desc)
> continue;
>

2014-11-15 15:20:50

by Dmitry Baryshkov

Subject: Re: [PATCH] genirq: Add IRQ 0 to domain debug file

Hello,

2014-11-15 16:01 GMT+03:00 Jiang Liu <[email protected]>:
> On 2014/11/15 19:27, Dmitry Eremin-Solenikov wrote:
>> Currently irq_domain_mapping debugfs file dumps IRQ information starting
>> from IRQ 1. IRQ 0 is missing from that file. Add it to have the complete
>> picture of IRQ/domains mappings.
> Hi Dmitry,
> For most irqdomain interfaces, they treat irq0 as invalid
> interrupt. But on x86, it's possible to use irq0 for timer. It causes
> may confusion when enabling irqdomain for x86.

I encountered with this issue when enabling IRQ domains support for
one of ARM sub-architectures.

--
With best wishes
Dmitry