Add the Loongson-2 High Precision Event Timer (HPET) binding
with DT schema format using json-schema.
Signed-off-by: Yinbo Zhu <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/timer/loongson,ls2k-hpet.yaml | 50 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
diff --git a/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
new file mode 100644
index 000000000000..30685c8fbead
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/loongson,ls2k-hpet.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Loongson-2 High Precision Event Timer (HPET)
+
+maintainers:
+ - Yinbo Zhu <[email protected]>
+
+properties:
+ compatible:
+ const: loongson,ls2k-hpet
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ items:
+ - description: SoC apb clock
+
+ clock-names:
+ items:
+ - const: apb
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - clock-names
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/loongson,ls2k-clk.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ timer@1fe24000 {
+ compatible = "loongson,ls2k-hpet";
+ reg = <0x1fe24000 0x15f>;
+ clocks = <&clk LOONGSON2_APB_CLK>;
+ clock-names = "apb";
+ interrupt-parent = <&liointc0>;
+ interrupts = <21 IRQ_TYPE_LEVEL_LOW>;
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index 52519695a458..939af260fe0f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -12030,6 +12030,7 @@ LOONGSON-2 SOC SERIES HPET DRIVER
M: Yinbo Zhu <[email protected]>
L: [email protected]
S: Maintained
+F: Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
F: drivers/clocksource/loongson2_hpet.c
LSILOGIC MPT FUSION DRIVERS (FC/SAS/SPI)
--
2.33.0
On Wed, 02 Nov 2022 11:52:49 +0800, Yinbo Zhu wrote:
> Add the Loongson-2 High Precision Event Timer (HPET) binding
> with DT schema format using json-schema.
>
> Signed-off-by: Yinbo Zhu <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/timer/loongson,ls2k-hpet.yaml | 50 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.example.dts:21:18: fatal error: dt-bindings/clock/loongson,ls2k-clk.h: No such file or directory
21 | #include <dt-bindings/clock/loongson,ls2k-clk.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [scripts/Makefile.lib:406: Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.example.dtb] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:1492: dt_binding_check] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
On Wed, Nov 2, 2022 at 6:16 AM Rob Herring <[email protected]> wrote:
>
>
> On Wed, 02 Nov 2022 11:52:49 +0800, Yinbo Zhu wrote:
> > Add the Loongson-2 High Precision Event Timer (HPET) binding
> > with DT schema format using json-schema.
> >
> > Signed-off-by: Yinbo Zhu <[email protected]>
> > Reviewed-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > .../bindings/timer/loongson,ls2k-hpet.yaml | 50 +++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 51 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/timer/loongson,ls2k-hpet.example.dts:21:18: fatal error: dt-bindings/clock/loongson,ls2k-clk.h: No such file or directory
> 21 | #include <dt-bindings/clock/loongson,ls2k-clk.h>
I assume this header is available somewhere else, but I have no idea.
Please describe dependencies below the '---' or no one can apply this.
Rob