This series adds support for the Allwinner V3-based SL631 family of
Action Cameras, starting with the IMX179 fashion.
A few fixes to V3 support are added along the way, most notably support
for the NMI IRQ controller which is necessary for the AXP209 IRQ.
Note that some patches in this series may have already been submitted
(but not yet merged) by others and are included for the series to build.
Changes since v2:
- Reused A80 binding for V3s NMI since registers are the same;
- Changes SL631 buttons (up/down/ok) which better reflect reality.
Changes since v1:
- Rework commit log messages as requested;
- Fixed v3s nmi controller compatible order in dt bindings doc;
- Changed SL631 compatible vendor to allwinner;
- Fixed LRADC button node names;
- Removed unused LDO4 regulator node;
- Removed merged patches.
Paul Kocialkowski (5):
dt-bindings: irq: sun7i-nmi: Add binding documentation for the V3s NMI
ARM: dts: sun8i-v3s: Add the V3s NMI IRQ controller
ARM: dts: sun8i: Cleanup the Pinecube AXP209 node
dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings
ARM: dts: sun8i-v3: Add support for the SL631 Action Camera with
IMX179
.../devicetree/bindings/arm/sunxi.yaml | 6 +
.../allwinner,sun7i-a20-sc-nmi.yaml | 3 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/sun8i-s3-pinecube.dts | 8 +-
arch/arm/boot/dts/sun8i-v3-sl631-imx179.dts | 12 ++
arch/arm/boot/dts/sun8i-v3-sl631.dtsi | 138 ++++++++++++++++++
arch/arm/boot/dts/sun8i-v3s.dtsi | 11 +-
7 files changed, 172 insertions(+), 7 deletions(-)
create mode 100644 arch/arm/boot/dts/sun8i-v3-sl631-imx179.dts
create mode 100644 arch/arm/boot/dts/sun8i-v3-sl631.dtsi
--
2.29.2
This adds documentation for the compatible strings of the
SL631 Action Camera with IMX179.
Note that the device is sold under various different names, such as the
SJCAM SJ4000 Air or F60 Action Camera. This is a similar situation to
the Q8 tablets and just like them, the allwinner vendor is used as
fallback.
Signed-off-by: Paul Kocialkowski <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
index 93e608aecae2..fd83805a2dfc 100644
--- a/Documentation/devicetree/bindings/arm/sunxi.yaml
+++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
@@ -777,6 +777,12 @@ properties:
- const: sinlinx,sina33
- const: allwinner,sun8i-a33
+ - description: SL631 Action Camera with IMX179
+ items:
+ - const: allwinner,sl631-imx179
+ - const: allwinner,sl631
+ - const: allwinner,sun8i-v3
+
- description: Tanix TX6
items:
- const: oranth,tanix-tx6
--
2.29.2
The V3s NMI controller seems register-compatible with the A80 (sun9i).
Add new items for the compatible string, with an entry specific to the V3s
and the A80 entry.
Signed-off-by: Paul Kocialkowski <[email protected]>
---
.../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
index 8acca0ae3129..4fd1e2780026 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml
@@ -29,6 +29,9 @@ properties:
- items:
- const: allwinner,sun8i-a83t-r-intc
- const: allwinner,sun6i-a31-r-intc
+ - items:
+ - const: allwinner,sun8i-v3s-nmi
+ - const: allwinner,sun9i-a80-nmi
- const: allwinner,sun9i-a80-nmi
- items:
- const: allwinner,sun50i-a64-r-intc
--
2.29.2
On Sun, 06 Dec 2020 17:51:27 +0100, Paul Kocialkowski wrote:
> The V3s NMI controller seems register-compatible with the A80 (sun9i).
> Add new items for the compatible string, with an entry specific to the V3s
> and the A80 entry.
>
> Signed-off-by: Paul Kocialkowski <[email protected]>
> ---
> .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
On Sun, Dec 06, 2020 at 05:51:26PM +0100, Paul Kocialkowski wrote:
> This series adds support for the Allwinner V3-based SL631 family of
> Action Cameras, starting with the IMX179 fashion.
>
> A few fixes to V3 support are added along the way, most notably support
> for the NMI IRQ controller which is necessary for the AXP209 IRQ.
>
> Note that some patches in this series may have already been submitted
> (but not yet merged) by others and are included for the series to build.
Queued all patches for 5.12
Thanks!
Maxime
Hi,
On Mon 07 Dec 20, 12:23, Rob Herring wrote:
> On Sun, 06 Dec 2020 17:51:27 +0100, Paul Kocialkowski wrote:
> > The V3s NMI controller seems register-compatible with the A80 (sun9i).
> > Add new items for the compatible string, with an entry specific to the V3s
> > and the A80 entry.
> >
> > Signed-off-by: Paul Kocialkowski <[email protected]>
> > ---
> > .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
Ah sorry, it was indeed intentional as there was a change since this version
uses sun9i-a80 as a base and I also renamed the compatible.
I put that in the cover letter's changelog but maybe it wasn't very explicit.
Cheers,
Paul
--
Developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
On Wed, Dec 9, 2020 at 8:11 AM Paul Kocialkowski <[email protected]> wrote:
>
> Hi,
>
> On Mon 07 Dec 20, 12:23, Rob Herring wrote:
> > On Sun, 06 Dec 2020 17:51:27 +0100, Paul Kocialkowski wrote:
> > > The V3s NMI controller seems register-compatible with the A80 (sun9i).
> > > Add new items for the compatible string, with an entry specific to the V3s
> > > and the A80 entry.
> > >
> > > Signed-off-by: Paul Kocialkowski <[email protected]>
> > > ---
> > > .../interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml | 3 +++
> > > 1 file changed, 3 insertions(+)
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> Ah sorry, it was indeed intentional as there was a change since this version
> uses sun9i-a80 as a base and I also renamed the compatible.
>
> I put that in the cover letter's changelog but maybe it wasn't very explicit.
Okay.
Reviewed-by: Rob Herring <[email protected]>