This file is ignored by git by the '.*' rule in the top .gitignore.
I do not see a good reason why this should be a hidden file.
Signed-off-by: Masahiro Yamada <[email protected]>
---
I think many people are aware of this issue
since this is now W=1 warning due to this patch:
https://lore.kernel.org/all/[email protected]/
Documentation/devicetree/bindings/Makefile | 4 ++--
Documentation/devicetree/bindings/{.yamllint => yamllint} | 0
2 files changed, 2 insertions(+), 2 deletions(-)
rename Documentation/devicetree/bindings/{.yamllint => yamllint} (100%)
diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index bf2d8a8ced77..edc65522072b 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -34,7 +34,7 @@ CHK_DT_DOCS := $(shell $(find_cmd))
quiet_cmd_yamllint = LINT $(src)
cmd_yamllint = ($(find_cmd) | \
xargs -n200 -P$$(nproc) \
- $(DT_SCHEMA_LINT) -f parsable -c $(srctree)/$(src)/.yamllint >&2) || true
+ $(DT_SCHEMA_LINT) -f parsable -c $(srctree)/$(src)/yamllint >&2) || true
quiet_cmd_chk_bindings = CHKDT $@
cmd_chk_bindings = ($(find_cmd) | \
@@ -64,7 +64,7 @@ override DTC_FLAGS := \
# Disable undocumented compatible checks until warning free
override DT_CHECKER_FLAGS ?=
-$(obj)/processed-schema.json: $(DT_DOCS) $(src)/.yamllint check_dtschema_version FORCE
+$(obj)/processed-schema.json: $(DT_DOCS) $(src)/yamllint check_dtschema_version FORCE
$(call if_changed_rule,chkdt)
always-y += processed-schema.json
diff --git a/Documentation/devicetree/bindings/.yamllint b/Documentation/devicetree/bindings/yamllint
similarity index 100%
rename from Documentation/devicetree/bindings/.yamllint
rename to Documentation/devicetree/bindings/yamllint
--
2.34.1
On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <[email protected]> wrote:
>
> This file is ignored by git by the '.*' rule in the top .gitignore.
>
> I do not see a good reason why this should be a hidden file.
Only because that is the default name yamllint will pick up if it is
run from the bindings directory. Not really something I do though.
Rob
On Tue, Jan 31, 2023 at 4:53 AM Rob Herring <[email protected]> wrote:
>
> On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <[email protected]> wrote:
> >
> > This file is ignored by git by the '.*' rule in the top .gitignore.
> >
> > I do not see a good reason why this should be a hidden file.
>
> Only because that is the default name yamllint will pick up if it is
> run from the bindings directory. Not really something I do though.
>
> Rob
Or, do you prefer adding
!/.yamllint
to Documentation/devicetree/bindings/.gitignore ?
--
Best Regards
Masahiro Yamada
On 31/01/2023 02:54, Masahiro Yamada wrote:
> On Tue, Jan 31, 2023 at 4:53 AM Rob Herring <[email protected]> wrote:
>>
>> On Mon, Jan 30, 2023 at 10:26 AM Masahiro Yamada <[email protected]> wrote:
>>>
>>> This file is ignored by git by the '.*' rule in the top .gitignore.
>>>
>>> I do not see a good reason why this should be a hidden file.
>>
>> Only because that is the default name yamllint will pick up if it is
>> run from the bindings directory. Not really something I do though.
>>
>> Rob
>
>
> Or, do you prefer adding
>
> !/.yamllint
>
> to Documentation/devicetree/bindings/.gitignore ?
https://lore.kernel.org/all/[email protected]/
Best regards,
Krzysztof