2020-11-30 20:31:53

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH 1/6] dt-bindings: display: add Unisoc's drm master bindings

On Mon, Nov 30, 2020 at 7:28 AM Kevin Tang <[email protected]> wrote:
>
> From: Kevin Tang <[email protected]>

Once again, DT patches must Cc the DT list if you want them reviewed.

>
> The Unisoc DRM master device is a virtual device needed to list all
> DPU devices or other display interface nodes that comprise the
> graphics subsystem
>
> Cc: Orson Zhai <[email protected]>
> Cc: Chunyan Zhang <[email protected]>
> Signed-off-by: Kevin Tang <[email protected]>
> ---
> .../display/sprd/sprd,display-subsystem.yaml | 39 ++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
> new file mode 100644
> index 0000000..9487a39
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sprd/sprd,display-subsystem.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sprd/sprd,display-subsystem.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Unisoc DRM master device
> +
> +maintainers:
> + - Kevin Tang <[email protected]>
> +
> +description: |
> + The Unisoc DRM master device is a virtual device needed to list all
> + DPU devices or other display interface nodes that comprise the
> + graphics subsystem.
> +
> +properties:
> + compatible:
> + const: sprd,display-subsystem

As I said before, we try to avoid these virtual nodes. Make the DRM
driver bind to the DPU node.

The case where this might be needed is if you have h/w that's a
mixture of shared and discrete blocks. I don't see anything here
matching that.

Rob