2019-04-09 19:13:02

by Andreas Klinger

Subject: [PATCH 2/3] devantech-srf04.yaml: add Maxbotix ultrasonic iio proximity sensors

add compatibles for Maxbotix ultrasonic iio sensor types to yaml
documentation

Signed-off-by: Andreas Klinger <[email protected]>
---
.../bindings/iio/proximity/devantech-srf04.yaml | 25 ++++++++++++++--------
1 file changed, 16 insertions(+), 9 deletions(-)

diff --git a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
index e7aab785c97d..4e80ea7c1475 100644
--- a/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
+++ b/Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml
@@ -4,7 +4,7 @@
$id: http://devicetree.org/schemas/iio/proximity/devantech-srf04.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

-title: Devantech SRF04 ultrasonic range finder
+title: Devantech SRF04 and Maxbotix mb1000 ultrasonic range finder

maintainers:
- Andreas Klinger <[email protected]>
@@ -16,19 +16,28 @@ description: |
- echo-gpio is held high by the sensor after sending ultrasonic burst
until it is received once again

- Specifications about the driver can be found at:
+ Specifications about the devices can be found at:
http://www.robot-electronics.co.uk/htm/srf04tech.htm

+ http://www.maxbotix.com/documents/LV-MaxSonar-EZ_Datasheet.pdf
+
properties:
compatible:
- items:
- - const: devantech,srf04
+ enum:
+ - devantech,srf04
+ - maxbotix,mb1000
+ - maxbotix,mb1010
+ - maxbotix,mb1020
+ - maxbotix,mb1030
+ - maxbotix,mb1040

trig-gpios:
description:
- Definition of the GPIO for the triggering (output) This GPIO is set
- for about 10 us by the driver to tell the device it should initiate
- the measurement cycle.
+ Definition of the GPIO for the triggering (output)
+ This GPIO is set for about 10 us by the driver to tell the device it
+ should initiate the measurement cycle.
+ See Documentation/devicetree/bindings/gpio/gpio.txt for information
+ on how to specify a consumer gpio.
maxItems: 1

echo-gpios:
@@ -40,8 +49,6 @@ properties:
trip.
It needs to be an GPIO which is able to deliver an interrupt because
the time between two interrupts is measured in the driver.
- See Documentation/devicetree/bindings/gpio/gpio.txt for information
- on how to specify a consumer gpio.
maxItems: 1

required:
--
2.11.0

2019-04-09 21:09:05

by Rob Herring

Subject: Re: [PATCH 2/3] devantech-srf04.yaml: add Maxbotix ultrasonic iio proximity sensors

On Tue, Apr 9, 2019 at 2:11 PM Andreas Klinger <[email protected]> wrote:
>
> add compatibles for Maxbotix ultrasonic iio sensor types to yaml
> documentation
>
> Signed-off-by: Andreas Klinger <[email protected]>
> ---
> .../bindings/iio/proximity/devantech-srf04.yaml | 25 ++++++++++++++--------
> 1 file changed, 16 insertions(+), 9 deletions(-)

In the future, 'dt-bindings: iio: ...' for the subject please.

Reviewed-by: Rob Herring <[email protected]>

2019-04-14 13:09:29

by Jonathan Cameron

Subject: Re: [PATCH 2/3] devantech-srf04.yaml: add Maxbotix ultrasonic iio proximity sensors

On Tue, 9 Apr 2019 16:08:02 -0500
Rob Herring <[email protected]> wrote:

> On Tue, Apr 9, 2019 at 2:11 PM Andreas Klinger <[email protected]> wrote:
> >
> > add compatibles for Maxbotix ultrasonic iio sensor types to yaml
> > documentation
> >
> > Signed-off-by: Andreas Klinger <[email protected]>
> > ---
> > .../bindings/iio/proximity/devantech-srf04.yaml | 25 ++++++++++++++--------
> > 1 file changed, 16 insertions(+), 9 deletions(-)
>
> In the future, 'dt-bindings: iio: ...' for the subject please.
>
> Reviewed-by: Rob Herring <[email protected]>

Applied and subject tidied up.

Thanks,

Jonathan