2022-02-09 12:54:41

by Oleksij Rempel

[permalink] [raw]
Subject: [PATCH net-next v1] dt-bindings: net: ethernet-controller: document label property

"label" provides human readable name used on a box, board or schematic
to identify Ethernet port.

Signed-off-by: Oleksij Rempel <[email protected]>
---
.../devicetree/bindings/net/ethernet-controller.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
index 34c5463abcec..817794e56227 100644
--- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
+++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
@@ -13,6 +13,10 @@ properties:
$nodename:
pattern: "^ethernet(@.*)?$"

+ label:
+ $ref: /schemas/types.yaml#/definitions/string
+ description: Human readable label on a port of a box.
+
local-mac-address:
description:
Specifies the MAC address that was assigned to the network device.
--
2.30.2



2022-02-09 18:15:31

by Oleksij Rempel

[permalink] [raw]
Subject: Re: [PATCH net-next v1] dt-bindings: net: ethernet-controller: document label property

On Wed, Feb 09, 2022 at 09:34:36AM -0600, Rob Herring wrote:
> On Wed, Feb 9, 2022 at 2:28 AM Oleksij Rempel <[email protected]> wrote:
> >
> > "label" provides human readable name used on a box, board or schematic
> > to identify Ethernet port.
>
> Do you still need this?

Yes. No need to force label based name from kernel, but user space
should be able to use it to rename interface if needed or use it for
GUI. Otherwise user space will need to have date base of all boards to
provide this information.

Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2022-02-09 20:38:34

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH net-next v1] dt-bindings: net: ethernet-controller: document label property

On Wed, Feb 9, 2022 at 2:28 AM Oleksij Rempel <[email protected]> wrote:
>
> "label" provides human readable name used on a box, board or schematic
> to identify Ethernet port.

Do you still need this?

> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/net/ethernet-controller.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index 34c5463abcec..817794e56227 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -13,6 +13,10 @@ properties:
> $nodename:
> pattern: "^ethernet(@.*)?$"
>
> + label:
> + $ref: /schemas/types.yaml#/definitions/string
> + description: Human readable label on a port of a box.
> +
> local-mac-address:
> description:
> Specifies the MAC address that was assigned to the network device.
> --
> 2.30.2
>

2022-02-14 18:56:27

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH net-next v1] dt-bindings: net: ethernet-controller: document label property

On Wed, 09 Feb 2022 09:28:20 +0100, Oleksij Rempel wrote:
> "label" provides human readable name used on a box, board or schematic
> to identify Ethernet port.
>
> Signed-off-by: Oleksij Rempel <[email protected]>
> ---
> .../devicetree/bindings/net/ethernet-controller.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

Applied, thanks!