2022-07-21 14:39:45

by Vidya Sagar

Subject: [PATCH V6 14/16] PCI: tegra194: Fix link up retry sequence

Add the missing DLF capability offset while clearing
DL_FEATURE_EXCHANGE_EN bit during link up retry.

Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support")
Signed-off-by: Vidya Sagar <[email protected]>
---
V6:
* New addition in V6 based on Bjorn's review comment

drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
index 39f7ae61fdc6..bac2e1ad0a29 100644
--- a/drivers/pci/controller/dwc/pcie-tegra194.c
+++ b/drivers/pci/controller/dwc/pcie-tegra194.c
@@ -967,7 +967,7 @@ static int tegra_pcie_dw_start_link(struct dw_pcie *pci)
offset = dw_pcie_find_ext_capability(pci, PCI_EXT_CAP_ID_DLF);
val = dw_pcie_readl_dbi(pci, offset + PCI_DLF_CAP);
val &= ~PCI_DLF_EXCHANGE_ENABLE;
- dw_pcie_writel_dbi(pci, offset, val);
+ dw_pcie_writel_dbi(pci, offset + PCI_DLF_CAP, val);

tegra_pcie_dw_host_init(pp);
dw_pcie_setup_rc(pp);
--
2.17.1

2022-07-22 22:33:58

by Rob Herring

Subject: Re: [PATCH V6 14/16] PCI: tegra194: Fix link up retry sequence

On Thu, Jul 21, 2022 at 8:22 AM Vidya Sagar <[email protected]> wrote:
>
> Add the missing DLF capability offset while clearing
> DL_FEATURE_EXCHANGE_EN bit during link up retry.
>
> Fixes: 56e15a238d92 ("PCI: tegra: Add Tegra194 PCIe support")
> Signed-off-by: Vidya Sagar <[email protected]>
> ---
> V6:
> * New addition in V6 based on Bjorn's review comment

Fixes first, then features. This either be first or not even in this
series. Unless you want to wait on the whole thing to be reviewed.

Though between this and patch 10, I wonder if this driver even worked upstream?

>
> drivers/pci/controller/dwc/pcie-tegra194.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Rob Herring <[email protected]>