2023-12-21 14:22:50

by Michal Simek

[permalink] [raw]
Subject: [PATCH] dt-bindings: serial: Describe ARM dcc interface

Debug Communication Channel (DCC) provides the way how to pass data between
target CPU and host via JTAG interface. Every CPU has own interface for
communication via dbgdtrtx_el0 and dbgdtrrx_el0 registers.

Signed-off-by: Michal Simek <[email protected]>
---

This communication interface is used for flash programming on Xilinx
SOCs from U-Boot.
https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/serial/arm_dcc.c

---
.../devicetree/bindings/serial/arm,dcc.yaml | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 Documentation/devicetree/bindings/serial/arm,dcc.yaml

diff --git a/Documentation/devicetree/bindings/serial/arm,dcc.yaml b/Documentation/devicetree/bindings/serial/arm,dcc.yaml
new file mode 100644
index 000000000000..fd0589356617
--- /dev/null
+++ b/Documentation/devicetree/bindings/serial/arm,dcc.yaml
@@ -0,0 +1,30 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/serial/arm,dcc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ARM DCC (Data communication channel) serial emulation
+
+maintainers:
+ - Michal Simek <[email protected]>
+
+description: |
+ ARM DCC (Data communication channel) serial emulation interface available
+ via JTAG can be also used as one of serial line tightly coupled with every
+ ARM CPU available in the system.
+
+properties:
+ compatible:
+ const: arm,dcc
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ serial {
+ compatible = "arm,dcc";
+ };
--
2.36.1



2023-12-21 21:12:07

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: serial: Describe ARM dcc interface


On Thu, 21 Dec 2023 15:05:09 +0100, Michal Simek wrote:
> Debug Communication Channel (DCC) provides the way how to pass data between
> target CPU and host via JTAG interface. Every CPU has own interface for
> communication via dbgdtrtx_el0 and dbgdtrrx_el0 registers.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> This communication interface is used for flash programming on Xilinx
> SOCs from U-Boot.
> https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/serial/arm_dcc.c
>
> ---
> .../devicetree/bindings/serial/arm,dcc.yaml | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/arm,dcc.yaml
>

Reviewed-by: Rob Herring <[email protected]>


2023-12-22 08:21:21

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: serial: Describe ARM dcc interface

On 21/12/2023 15:05, Michal Simek wrote:
> Debug Communication Channel (DCC) provides the way how to pass data between
> target CPU and host via JTAG interface. Every CPU has own interface for
> communication via dbgdtrtx_el0 and dbgdtrrx_el0 registers.
>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> This communication interface is used for flash programming on Xilinx
> SOCs from U-Boot.
> https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/serial/arm_dcc.c
>
> ---
> .../devicetree/bindings/serial/arm,dcc.yaml | 30 +++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/serial/arm,dcc.yaml
>
> diff --git a/Documentation/devicetree/bindings/serial/arm,dcc.yaml b/Documentation/devicetree/bindings/serial/arm,dcc.yaml
> new file mode 100644
> index 000000000000..fd0589356617
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/serial/arm,dcc.yaml
> @@ -0,0 +1,30 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/serial/arm,dcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM DCC (Data communication channel) serial emulation
> +
> +maintainers:
> + - Michal Simek <[email protected]>
> +
> +description: |
> + ARM DCC (Data communication channel) serial emulation interface available
> + via JTAG can be also used as one of serial line tightly coupled with every
> + ARM CPU available in the system.
> +
> +properties:
> + compatible:
> + const: arm,dcc
> +
> +required:
> + - compatible

no allOf: with $ref to serial.yaml? Does it differ somehow?

Best regards,
Krzysztof


2024-01-02 15:33:01

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: serial: Describe ARM dcc interface



On 12/22/23 09:20, Krzysztof Kozlowski wrote:
> On 21/12/2023 15:05, Michal Simek wrote:
>> Debug Communication Channel (DCC) provides the way how to pass data between
>> target CPU and host via JTAG interface. Every CPU has own interface for
>> communication via dbgdtrtx_el0 and dbgdtrrx_el0 registers.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>> ---
>>
>> This communication interface is used for flash programming on Xilinx
>> SOCs from U-Boot.
>> https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/serial/arm_dcc.c
>>
>> ---
>> .../devicetree/bindings/serial/arm,dcc.yaml | 30 +++++++++++++++++++
>> 1 file changed, 30 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/serial/arm,dcc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/serial/arm,dcc.yaml b/Documentation/devicetree/bindings/serial/arm,dcc.yaml
>> new file mode 100644
>> index 000000000000..fd0589356617
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/serial/arm,dcc.yaml
>> @@ -0,0 +1,30 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/serial/arm,dcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: ARM DCC (Data communication channel) serial emulation
>> +
>> +maintainers:
>> + - Michal Simek <[email protected]>
>> +
>> +description: |
>> + ARM DCC (Data communication channel) serial emulation interface available
>> + via JTAG can be also used as one of serial line tightly coupled with every
>> + ARM CPU available in the system.
>> +
>> +properties:
>> + compatible:
>> + const: arm,dcc
>> +
>> +required:
>> + - compatible
>
> no allOf: with $ref to serial.yaml? Does it differ somehow?

Valid one could be only nodename format and maybe label.
Others are not relevant. But if that's fine I can also add it.

Thanks,
Michal


2024-01-03 20:27:14

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: serial: Describe ARM dcc interface

On Tue, Jan 2, 2024 at 8:32 AM Michal Simek <[email protected]> wrote:
>
>
>
> On 12/22/23 09:20, Krzysztof Kozlowski wrote:
> > On 21/12/2023 15:05, Michal Simek wrote:
> >> Debug Communication Channel (DCC) provides the way how to pass data between
> >> target CPU and host via JTAG interface. Every CPU has own interface for
> >> communication via dbgdtrtx_el0 and dbgdtrrx_el0 registers.
> >>
> >> Signed-off-by: Michal Simek <[email protected]>
> >> ---
> >>
> >> This communication interface is used for flash programming on Xilinx
> >> SOCs from U-Boot.
> >> https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/serial/arm_dcc.c
> >>
> >> ---
> >> .../devicetree/bindings/serial/arm,dcc.yaml | 30 +++++++++++++++++++
> >> 1 file changed, 30 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/serial/arm,dcc.yaml
> >>
> >> diff --git a/Documentation/devicetree/bindings/serial/arm,dcc.yaml b/Documentation/devicetree/bindings/serial/arm,dcc.yaml
> >> new file mode 100644
> >> index 000000000000..fd0589356617
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/serial/arm,dcc.yaml
> >> @@ -0,0 +1,30 @@
> >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/serial/arm,dcc.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: ARM DCC (Data communication channel) serial emulation
> >> +
> >> +maintainers:
> >> + - Michal Simek <[email protected]>
> >> +
> >> +description: |
> >> + ARM DCC (Data communication channel) serial emulation interface available
> >> + via JTAG can be also used as one of serial line tightly coupled with every
> >> + ARM CPU available in the system.
> >> +
> >> +properties:
> >> + compatible:
> >> + const: arm,dcc
> >> +
> >> +required:
> >> + - compatible
> >
> > no allOf: with $ref to serial.yaml? Does it differ somehow?
>
> Valid one could be only nodename format and maybe label.
> Others are not relevant. But if that's fine I can also add it.

Yeah, I think serial.yaml mostly doesn't apply here. Not really worth
including for just the node name.

Greg may have already processed this, so you might want to resend. Or
wait a few days and I'll just apply it.

Rob