Duplicated unit address is a normal case, as long as no more than one
node using that address is enabled. Having duplicated addresses is
already allowed by '-Wno-unique_unit_address' in DTC_FLAGS. But two
simultaneously enabled nodes sharing the same address is usually
incorrect. Add '-Wunique_unit_address_if_enabled' flag to report
warnings for such case when doing "make dtbs_check".
Signed-off-by: Sam Protsenko <[email protected]>
Reported-by: Rob Herring <[email protected]>
Suggested-by: Rob Herring <[email protected]>
---
NOTE: After applying this patch, a lot of warnings appear on "make
dtbs_check". I'm not completely sure if it's ok, so feel free to Nack.
scripts/Makefile.lib | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index ce6142238835..2f00c996d2e3 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -315,7 +315,8 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \
-Wno-alias_paths \
-Wno-graph_child_address \
-Wno-simple_bus_reg \
- -Wno-unique_unit_address
+ -Wno-unique_unit_address \
+ -Wunique_unit_address_if_enabled
endif
ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)
--
2.30.2
On Tue, 7 Dec 2021 at 16:03, Sam Protsenko <[email protected]> wrote:
>
> Duplicated unit address is a normal case, as long as no more than one
> node using that address is enabled. Having duplicated addresses is
> already allowed by '-Wno-unique_unit_address' in DTC_FLAGS. But two
> simultaneously enabled nodes sharing the same address is usually
> incorrect. Add '-Wunique_unit_address_if_enabled' flag to report
> warnings for such case when doing "make dtbs_check".
>
> Signed-off-by: Sam Protsenko <[email protected]>
> Reported-by: Rob Herring <[email protected]>
> Suggested-by: Rob Herring <[email protected]>
> ---
> NOTE: After applying this patch, a lot of warnings appear on "make
> dtbs_check". I'm not completely sure if it's ok, so feel free to Nack.
>
Hi Rob,
Do you think this patch is feasible? You asked me to send it before,
though I now see it leads to a lot of errors being revealed when doing
"make dtbs" and "make dtbs_check". Please let me know if it's Ack or
Nack -- I'm fine with any resolution, just want to know if I should
continue to carry it in my local branch or drop it.
Thanks!
> scripts/Makefile.lib | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index ce6142238835..2f00c996d2e3 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -315,7 +315,8 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \
> -Wno-alias_paths \
> -Wno-graph_child_address \
> -Wno-simple_bus_reg \
> - -Wno-unique_unit_address
> + -Wno-unique_unit_address \
> + -Wunique_unit_address_if_enabled
> endif
>
> ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)
> --
> 2.30.2
>
On Wed, Dec 15, 2021 at 1:11 AM Sam Protsenko
<[email protected]> wrote:
>
> On Tue, 7 Dec 2021 at 16:03, Sam Protsenko <[email protected]> wrote:
> >
> > Duplicated unit address is a normal case, as long as no more than one
> > node using that address is enabled. Having duplicated addresses is
> > already allowed by '-Wno-unique_unit_address' in DTC_FLAGS. But two
> > simultaneously enabled nodes sharing the same address is usually
> > incorrect. Add '-Wunique_unit_address_if_enabled' flag to report
> > warnings for such case when doing "make dtbs_check".
> >
> > Signed-off-by: Sam Protsenko <[email protected]>
> > Reported-by: Rob Herring <[email protected]>
> > Suggested-by: Rob Herring <[email protected]>
> > ---
> > NOTE: After applying this patch, a lot of warnings appear on "make
> > dtbs_check". I'm not completely sure if it's ok, so feel free to Nack.
> >
>
> Hi Rob,
>
> Do you think this patch is feasible? You asked me to send it before,
> though I now see it leads to a lot of errors being revealed when doing
> "make dtbs" and "make dtbs_check". Please let me know if it's Ack or
> Nack -- I'm fine with any resolution, just want to know if I should
> continue to carry it in my local branch or drop it.
>
> Thanks!
This is up to Rob.
I do not mind either way.
>
> > scripts/Makefile.lib | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> > index ce6142238835..2f00c996d2e3 100644
> > --- a/scripts/Makefile.lib
> > +++ b/scripts/Makefile.lib
> > @@ -315,7 +315,8 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \
> > -Wno-alias_paths \
> > -Wno-graph_child_address \
> > -Wno-simple_bus_reg \
> > - -Wno-unique_unit_address
> > + -Wno-unique_unit_address \
> > + -Wunique_unit_address_if_enabled
> > endif
> >
> > ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)
> > --
> > 2.30.2
> >
--
Best Regards
Masahiro Yamada
On Tue, Dec 14, 2021 at 10:11 AM Sam Protsenko
<[email protected]> wrote:
>
> On Tue, 7 Dec 2021 at 16:03, Sam Protsenko <[email protected]> wrote:
> >
> > Duplicated unit address is a normal case, as long as no more than one
> > node using that address is enabled. Having duplicated addresses is
> > already allowed by '-Wno-unique_unit_address' in DTC_FLAGS. But two
> > simultaneously enabled nodes sharing the same address is usually
> > incorrect. Add '-Wunique_unit_address_if_enabled' flag to report
> > warnings for such case when doing "make dtbs_check".
> >
> > Signed-off-by: Sam Protsenko <[email protected]>
> > Reported-by: Rob Herring <[email protected]>
> > Suggested-by: Rob Herring <[email protected]>
> > ---
> > NOTE: After applying this patch, a lot of warnings appear on "make
> > dtbs_check". I'm not completely sure if it's ok, so feel free to Nack.
> >
>
> Hi Rob,
>
> Do you think this patch is feasible? You asked me to send it before,
> though I now see it leads to a lot of errors being revealed when doing
> "make dtbs" and "make dtbs_check". Please let me know if it's Ack or
> Nack -- I'm fine with any resolution, just want to know if I should
> continue to carry it in my local branch or drop it.
Sorry, I'd missed this. Anyway, since there are lots of warnings, we
can't apply this.
Rob