2022-04-27 10:11:07

by Drew Fustini

[permalink] [raw]
Subject: [PATCH v2 1/2] dt-bindings: wkup-m3-ipc: Add ti,scale-data-fw property

From: Dave Gerlach <[email protected]>

Add documentation for ti,scale-data-fw property to enable I2C PMIC
voltage scaling during deep sleep. The property contains the name of a
binary file for the CM3 firmware to load.

Based on previous work by Russ Dill.

Signed-off-by: Dave Gerlach <[email protected]>
Signed-off-by: Keerthy <[email protected]>
[dfustini: split from driver patch and convert to json-schema]
Signed-off-by: Drew Fustini <[email protected]>
---
Changes from v1:
- change 'ti,scale-data-fw' to 'firmware-name'
- add 'firmware-name' property to the examples

.../devicetree/bindings/soc/ti/wkup-m3-ipc.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
index 88d690de050c..fc8fa6ba8c43 100644
--- a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
@@ -40,6 +40,12 @@ description: |+
override the pin's existing bias (pull-up/pull-down) and value (high/low) when
IO isolation is active.

+ Support for I2C PMIC Voltage Scaling
+ ====================================
+ It is possible to pass the name of a binary file to load into the CM3 memory.
+ The binary data is the I2C sequences for the CM3 to send out to the PMIC
+ during low power mode entry.
+
properties:
compatible:
enum:
@@ -67,6 +73,10 @@ properties:
mbox_wkupm3 child node.
maxItems: 1

+ firmware-name:
+ description:
+ Name of binary file with I2C sequences for PMIC voltage scaling
+
ti,vtt-gpio-pin:
$ref: /schemas/types.yaml#/definitions/uint32
description: GPIO pin connected to enable pin on VTT regulator
@@ -117,6 +127,7 @@ examples:
ti,rproc = <&wkup_m3>;
mboxes = <&am335x_mailbox &mbox_wkupm3>;
ti,vtt-gpio-pin = <7>;
+ firmware-name = "am335x-evm-scale-data.bin";
};
};

@@ -157,6 +168,7 @@ examples:
ti,rproc = <&wkup_m3>;
mboxes = <&am437x_mailbox &mbox_wkupm3>;
ti,set-io-isolation;
+ firmware-name = "am43x-evm-scale-data.bin";
};
};

--
2.32.0


2022-05-02 17:33:43

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: wkup-m3-ipc: Add ti,scale-data-fw property

On Fri, Apr 29, 2022 at 5:14 PM Rob Herring <[email protected]> wrote:
>
> On Tue, 26 Apr 2022 12:32:52 -0700, Drew Fustini wrote:
> > From: Dave Gerlach <[email protected]>
> >
> > Add documentation for ti,scale-data-fw property to enable I2C PMIC
> > voltage scaling during deep sleep. The property contains the name of a
> > binary file for the CM3 firmware to load.
> >
> > Based on previous work by Russ Dill.
> >
> > Signed-off-by: Dave Gerlach <[email protected]>
> > Signed-off-by: Keerthy <[email protected]>
> > [dfustini: split from driver patch and convert to json-schema]
> > Signed-off-by: Drew Fustini <[email protected]>
> > ---
> > Changes from v1:
> > - change 'ti,scale-data-fw' to 'firmware-name'
> > - add 'firmware-name' property to the examples
> >
> > .../devicetree/bindings/soc/ti/wkup-m3-ipc.yaml | 12 ++++++++++++
> > 1 file changed, 12 insertions(+)
> >
>
> Applied, thanks!

Err, picked v3 instead.

Rob

2022-05-03 00:48:00

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] dt-bindings: wkup-m3-ipc: Add ti,scale-data-fw property

On Tue, 26 Apr 2022 12:32:52 -0700, Drew Fustini wrote:
> From: Dave Gerlach <[email protected]>
>
> Add documentation for ti,scale-data-fw property to enable I2C PMIC
> voltage scaling during deep sleep. The property contains the name of a
> binary file for the CM3 firmware to load.
>
> Based on previous work by Russ Dill.
>
> Signed-off-by: Dave Gerlach <[email protected]>
> Signed-off-by: Keerthy <[email protected]>
> [dfustini: split from driver patch and convert to json-schema]
> Signed-off-by: Drew Fustini <[email protected]>
> ---
> Changes from v1:
> - change 'ti,scale-data-fw' to 'firmware-name'
> - add 'firmware-name' property to the examples
>
> .../devicetree/bindings/soc/ti/wkup-m3-ipc.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>

Applied, thanks!