2022-04-27 09:14:37

by Drew Fustini

[permalink] [raw]
Subject: [PATCH v3 0/2] soc: ti: wkup_m3_ipc: support i2c voltage scaling

Allow loading of a binary file containing i2c scaling sequences to be
provided to the Cortex-M3 firmware in order to properly scale voltage
rails on the PMIC during low power modes like DeepSleep0.

The 'firmware-name' property which contains the name of a binary file.

A prerequisite for this series is:
[PATCH v3 0/2] soc: ti: wkup_m3_ipc: Add support for IO Isolation
https://lore.kernel.org/linux-devicetree/[email protected]/

Changes from v2:
- correct the name of the property in the commit message of the bindings
patch to firmware-name instead of the old ti,scale-data-fw property

Changes from v1:
- change 'ti,scale-data-fw' to 'firmware-name'
- add 'firmware-name' property to the examples

Dave Gerlach (2):
dt-bindings: wkup-m3-ipc: Add firmware-name property
soc: ti: wkup_m3_ipc: Add support for i2c voltage scaling

.../bindings/soc/ti/wkup-m3-ipc.yaml | 12 +++
drivers/soc/ti/wkup_m3_ipc.c | 93 ++++++++++++++++++-
include/linux/wkup_m3_ipc.h | 9 ++
3 files changed, 113 insertions(+), 1 deletion(-)

--
2.32.0


2022-04-27 11:33:55

by Drew Fustini

[permalink] [raw]
Subject: [PATCH v3 1/2] dt-bindings: wkup-m3-ipc: Add firmware-name property

From: Dave Gerlach <[email protected]>

Document that the firmware-name property can be used to indicate a file
contains I2C sequences for PMIC voltage scaling during deep sleep.

Based on previous work by Russ Dill.

Signed-off-by: Dave Gerlach <[email protected]>
Signed-off-by: Keerthy <[email protected]>
[dfustini: split from driver patch and convert to json-schema]
Signed-off-by: Drew Fustini <[email protected]>
---
Changes from v2:
- fix the property name in this commit message

Changes from v1:
- change 'ti,scale-data-fw' to 'firmware-name'
- add 'firmware-name' property to the examples

.../devicetree/bindings/soc/ti/wkup-m3-ipc.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
index 88d690de050c..0df41c4f60c1 100644
--- a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml
@@ -40,6 +40,12 @@ description: |+
override the pin's existing bias (pull-up/pull-down) and value (high/low) when
IO isolation is active.

+ Support for I2C PMIC Voltage Scaling
+ ====================================
+ It is possible to pass the name of a binary file to load into the CM3 memory.
+ The binary data is the I2C sequences for the CM3 to send out to the PMIC
+ during low power mode entry.
+
properties:
compatible:
enum:
@@ -67,6 +73,10 @@ properties:
mbox_wkupm3 child node.
maxItems: 1

+ firmware-name:
+ description:
+ Name of binary file with I2C sequences for PMIC voltage scaling
+
ti,vtt-gpio-pin:
$ref: /schemas/types.yaml#/definitions/uint32
description: GPIO pin connected to enable pin on VTT regulator
@@ -117,6 +127,7 @@ examples:
ti,rproc = <&wkup_m3>;
mboxes = <&am335x_mailbox &mbox_wkupm3>;
ti,vtt-gpio-pin = <7>;
+ firmware-name = "am335x-evm-scale-data.bin";
};
};

@@ -157,6 +168,7 @@ examples:
ti,rproc = <&wkup_m3>;
mboxes = <&am437x_mailbox &mbox_wkupm3>;
ti,set-io-isolation;
+ firmware-name = "am43x-evm-scale-data.bin";
};
};

--
2.32.0

2022-05-02 23:03:14

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: wkup-m3-ipc: Add firmware-name property

On Tue, Apr 26, 2022 at 3:07 PM Drew Fustini <[email protected]> wrote:
>
> From: Dave Gerlach <[email protected]>
>
> Document that the firmware-name property can be used to indicate a file
> contains I2C sequences for PMIC voltage scaling during deep sleep.
>
> Based on previous work by Russ Dill.
>
> Signed-off-by: Dave Gerlach <[email protected]>
> Signed-off-by: Keerthy <[email protected]>
> [dfustini: split from driver patch and convert to json-schema]
> Signed-off-by: Drew Fustini <[email protected]>
> ---
> Changes from v2:
> - fix the property name in this commit message
>
> Changes from v1:
> - change 'ti,scale-data-fw' to 'firmware-name'
> - add 'firmware-name' property to the examples
>
> .../devicetree/bindings/soc/ti/wkup-m3-ipc.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)

Applied, thanks!

2022-05-03 13:29:19

by Nishanth Menon

[permalink] [raw]
Subject: Re: (subset) [PATCH v3 0/2] soc: ti: wkup_m3_ipc: support i2c voltage scaling

Hi Drew Fustini,

On Tue, 26 Apr 2022 13:07:40 -0700, Drew Fustini wrote:
> Allow loading of a binary file containing i2c scaling sequences to be
> provided to the Cortex-M3 firmware in order to properly scale voltage
> rails on the PMIC during low power modes like DeepSleep0.
>
> The 'firmware-name' property which contains the name of a binary file.
>
> A prerequisite for this series is:
> [PATCH v3 0/2] soc: ti: wkup_m3_ipc: Add support for IO Isolation
> https://lore.kernel.org/linux-devicetree/[email protected]/
>
> [...]

I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!

[2/2] soc: ti: wkup_m3_ipc: Add support for i2c voltage scaling
commit: ea082040fe071d2ba1f8f73792743d7ca9fb218e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D