2022-05-14 02:44:00

by Dipen Patel

[permalink] [raw]
Subject: [PATCH] dt-bindings: Renamed hte directory to timestamp

Renamed hte dt binding directory to timestamp according review comment.
Addressed minor comment about having HTE acronym first in the common dt
binding document.

The change reflects above renaming in MAINTAINERS files too.

Signed-off-by: Dipen Patel <[email protected]>
---
This patch is on top of old series (Intro to Hardware timestamping
engine V6) present in linux-next tentatively in preparation for
merge.

.../{hte => timestamp}/hardware-timestamps-common.yaml | 6 +++---
.../bindings/{hte => timestamp}/hte-consumer.yaml | 0
.../bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml | 0
MAINTAINERS | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/{hte => timestamp}/hardware-timestamps-common.yaml (71%)
rename Documentation/devicetree/bindings/{hte => timestamp}/hte-consumer.yaml (100%)
rename Documentation/devicetree/bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml (100%)

diff --git a/Documentation/devicetree/bindings/hte/hardware-timestamps-common.yaml b/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
similarity index 71%
rename from Documentation/devicetree/bindings/hte/hardware-timestamps-common.yaml
rename to Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
index 3e26de605f08..4c25ba248a72 100644
--- a/Documentation/devicetree/bindings/hte/hardware-timestamps-common.yaml
+++ b/Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml
@@ -10,9 +10,9 @@ maintainers:
- Dipen Patel <[email protected]>

description:
- Some devices/SoCs have hardware time stamping engines which can use hardware
- means to timestamp entity in realtime. The entity could be anything from
- GPIOs, IRQs, Bus and so on. The hardware timestamp engine (HTE) present
+ Some devices/SoCs have hardware timestamp engines (HTE) which can use
+ hardware means to timestamp entity in realtime. The entity could be anything
+ from GPIOs, IRQs, Bus and so on. The hardware timestamp engine present
itself as a provider with the bindings described in this document.

properties:
diff --git a/Documentation/devicetree/bindings/hte/hte-consumer.yaml b/Documentation/devicetree/bindings/timestamp/hte-consumer.yaml
similarity index 100%
rename from Documentation/devicetree/bindings/hte/hte-consumer.yaml
rename to Documentation/devicetree/bindings/timestamp/hte-consumer.yaml
diff --git a/Documentation/devicetree/bindings/hte/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
similarity index 100%
rename from Documentation/devicetree/bindings/hte/nvidia,tegra194-hte.yaml
rename to Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml
diff --git a/MAINTAINERS b/MAINTAINERS
index 4e1e6dbb1ad8..74a61ea4beef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9057,7 +9057,7 @@ F: drivers/input/touchscreen/htcpen.c
HTE SUBSYSTEM
M: Dipen Patel <[email protected]>
S: Maintained
-F: Documentation/devicetree/bindings/hte/
+F: Documentation/devicetree/bindings/timestamp/
F: Documentation/hte/
F: drivers/hte/
F: include/linux/hte.h

base-commit: 6107040c99d5dfc920721c198d45ed2d639b113a
--
2.17.1



2022-05-14 03:48:08

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Renamed hte directory to timestamp

On Thu, May 12, 2022 at 7:50 PM Dipen Patel <[email protected]> wrote:

> Renamed hte dt binding directory to timestamp according review comment.
> Addressed minor comment about having HTE acronym first in the common dt
> binding document.
>
> The change reflects above renaming in MAINTAINERS files too.
>
> Signed-off-by: Dipen Patel <[email protected]>
> ---
> This patch is on top of old series (Intro to Hardware timestamping
> engine V6) present in linux-next tentatively in preparation for
> merge.

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2022-05-18 04:16:39

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Renamed hte directory to timestamp

On Thu, 12 May 2022 10:50:11 -0700, Dipen Patel wrote:
> Renamed hte dt binding directory to timestamp according review comment.
> Addressed minor comment about having HTE acronym first in the common dt
> binding document.
>
> The change reflects above renaming in MAINTAINERS files too.
>
> Signed-off-by: Dipen Patel <[email protected]>
> ---
> This patch is on top of old series (Intro to Hardware timestamping
> engine V6) present in linux-next tentatively in preparation for
> merge.
>
> .../{hte => timestamp}/hardware-timestamps-common.yaml | 6 +++---
> .../bindings/{hte => timestamp}/hte-consumer.yaml | 0
> .../bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml | 0
> MAINTAINERS | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
> rename Documentation/devicetree/bindings/{hte => timestamp}/hardware-timestamps-common.yaml (71%)
> rename Documentation/devicetree/bindings/{hte => timestamp}/hte-consumer.yaml (100%)
> rename Documentation/devicetree/bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml (100%)
>

Acked-by: Rob Herring <[email protected]>

2022-05-23 16:07:12

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Renamed hte directory to timestamp

On Tue, May 17, 2022 at 7:35 PM Rob Herring <[email protected]> wrote:
>
> On Thu, 12 May 2022 10:50:11 -0700, Dipen Patel wrote:
> > Renamed hte dt binding directory to timestamp according review comment.
> > Addressed minor comment about having HTE acronym first in the common dt
> > binding document.
> >
> > The change reflects above renaming in MAINTAINERS files too.
> >
> > Signed-off-by: Dipen Patel <[email protected]>
> > ---
> > This patch is on top of old series (Intro to Hardware timestamping
> > engine V6) present in linux-next tentatively in preparation for
> > merge.
> >
> > .../{hte => timestamp}/hardware-timestamps-common.yaml | 6 +++---
> > .../bindings/{hte => timestamp}/hte-consumer.yaml | 0
> > .../bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml | 0
> > MAINTAINERS | 2 +-
> > 4 files changed, 4 insertions(+), 4 deletions(-)
> > rename Documentation/devicetree/bindings/{hte => timestamp}/hardware-timestamps-common.yaml (71%)
> > rename Documentation/devicetree/bindings/{hte => timestamp}/hte-consumer.yaml (100%)
> > rename Documentation/devicetree/bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml (100%)
> >
>
> Acked-by: Rob Herring <[email protected]>

I take that back:

./Documentation/devicetree/bindings/timestamp/hte-consumer.yaml: $id:
relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
./Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
./Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#


I was wondering why a new common binding was already in next without a
Reviewed-by, but I let that slide. Now I regret doing that.

Rob

2022-05-23 18:01:10

by Dipen Patel

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: Renamed hte directory to timestamp

Hi Rob,

I have just sent out the patch to fix this.

Best Regards,

Dipen Patel

On 5/23/22 9:05 AM, Rob Herring wrote:
> On Tue, May 17, 2022 at 7:35 PM Rob Herring <[email protected]> wrote:
>> On Thu, 12 May 2022 10:50:11 -0700, Dipen Patel wrote:
>>> Renamed hte dt binding directory to timestamp according review comment.
>>> Addressed minor comment about having HTE acronym first in the common dt
>>> binding document.
>>>
>>> The change reflects above renaming in MAINTAINERS files too.
>>>
>>> Signed-off-by: Dipen Patel <[email protected]>
>>> ---
>>> This patch is on top of old series (Intro to Hardware timestamping
>>> engine V6) present in linux-next tentatively in preparation for
>>> merge.
>>>
>>> .../{hte => timestamp}/hardware-timestamps-common.yaml | 6 +++---
>>> .../bindings/{hte => timestamp}/hte-consumer.yaml | 0
>>> .../bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml | 0
>>> MAINTAINERS | 2 +-
>>> 4 files changed, 4 insertions(+), 4 deletions(-)
>>> rename Documentation/devicetree/bindings/{hte => timestamp}/hardware-timestamps-common.yaml (71%)
>>> rename Documentation/devicetree/bindings/{hte => timestamp}/hte-consumer.yaml (100%)
>>> rename Documentation/devicetree/bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml (100%)
>>>
>> Acked-by: Rob Herring <[email protected]>
> I take that back:
>
> ./Documentation/devicetree/bindings/timestamp/hte-consumer.yaml: $id:
> relative path/filename doesn't match actual path or filename
> expected: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
> ./Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml:
> $id: relative path/filename doesn't match actual path or filename
> expected: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
> ./Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml:
> $id: relative path/filename doesn't match actual path or filename
> expected: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#
>
>
> I was wondering why a new common binding was already in next without a
> Reviewed-by, but I let that slide. Now I regret doing that.
>
> Rob