2023-07-17 23:16:25

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] ARM: keystone: Drop unused includes

Several includes are not needed, so drop them.

of_platform.h is not needed, but it implicitly includes platform_device.h
(for now) which is needed.

Signed-off-by: Rob Herring <[email protected]>
---
arch/arm/mach-keystone/keystone.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c
index 68039aad3014..e0ca26182e0b 100644
--- a/arch/arm/mach-keystone/keystone.c
+++ b/arch/arm/mach-keystone/keystone.c
@@ -7,12 +7,10 @@
* Santosh Shilimkar <[email protected]>
*/
#include <linux/io.h>
-#include <linux/of.h>
#include <linux/dma-map-ops.h>
#include <linux/init.h>
-#include <linux/of_platform.h>
-#include <linux/of_address.h>
#include <linux/memblock.h>
+#include <linux/platform_device.h>

#include <asm/setup.h>
#include <asm/mach/map.h>
--
2.40.1



2023-07-25 12:06:29

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH] ARM: keystone: Drop unused includes

Hi Rob Herring,

On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote:
> Several includes are not needed, so drop them.
>
> of_platform.h is not needed, but it implicitly includes platform_device.h
> (for now) which is needed.
>
>

I have applied the following to branch ti-keystone-next on [1].
Thank you!

[1/1] ARM: keystone: Drop unused includes
commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D


2023-08-23 06:56:22

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] ARM: keystone: Drop unused includes

On Tue, Jul 25, 2023 at 6:35 AM Nishanth Menon <[email protected]> wrote:
>
> Hi Rob Herring,
>
> On Mon, 17 Jul 2023 16:56:09 -0600, Rob Herring wrote:
> > Several includes are not needed, so drop them.
> >
> > of_platform.h is not needed, but it implicitly includes platform_device.h
> > (for now) which is needed.
> >
> >
>
> I have applied the following to branch ti-keystone-next on [1].
> Thank you!
>
> [1/1] ARM: keystone: Drop unused includes
> commit: 630c191b3396c6aaccab1234f8834848a2c42e8a

Did you really? Doesn't look like this is in linux-next.

Rob