2021-12-06 12:43:51

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks

While converting bindings to dtschema, the buck regulators lost
"op_mode" property. The "op_mode" is a valid property for all
regulators (both LDOs and bucks), so add it.

Reported-by: Rob Herring <[email protected]>
Fixes: fab58debc137 ("regulator: dt-bindings: samsung,s5m8767: convert to dtschema")
Cc: <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/regulator/samsung,s5m8767.yaml | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
index 80a63d47790a..c98929a213e9 100644
--- a/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
+++ b/Documentation/devicetree/bindings/regulator/samsung,s5m8767.yaml
@@ -51,6 +51,19 @@ patternProperties:
description:
Properties for single BUCK regulator.

+ properties:
+ op_mode:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [0, 1, 2, 3]
+ default: 1
+ description: |
+ Describes the different operating modes of the regulator with power
+ mode change in SOC. The different possible values are:
+ 0 - always off mode
+ 1 - on in normal mode
+ 2 - low power mode
+ 3 - suspend mode
+
required:
- regulator-name

@@ -63,6 +76,18 @@ patternProperties:
Properties for single BUCK regulator.

properties:
+ op_mode:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [0, 1, 2, 3]
+ default: 1
+ description: |
+ Describes the different operating modes of the regulator with power
+ mode change in SOC. The different possible values are:
+ 0 - always off mode
+ 1 - on in normal mode
+ 2 - low power mode
+ 3 - suspend mode
+
s5m8767,pmic-ext-control-gpios:
maxItems: 1
description: |
--
2.32.0



2021-12-06 17:31:40

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks

On Mon, Dec 6, 2021 at 6:43 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> While converting bindings to dtschema, the buck regulators lost
> "op_mode" property. The "op_mode" is a valid property for all
> regulators (both LDOs and bucks), so add it.
>
> Reported-by: Rob Herring <[email protected]>
> Fixes: fab58debc137 ("regulator: dt-bindings: samsung,s5m8767: convert to dtschema")
> Cc: <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../bindings/regulator/samsung,s5m8767.yaml | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)

Reviewed-by: Rob Herring <[email protected]>

2021-12-07 15:09:56

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks

On Mon, 6 Dec 2021 13:43:06 +0100, Krzysztof Kozlowski wrote:
> While converting bindings to dtschema, the buck regulators lost
> "op_mode" property. The "op_mode" is a valid property for all
> regulators (both LDOs and bucks), so add it.
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-linus

Thanks!

[1/1] regulator: dt-bindings: samsung,s5m8767: add missing op_mode to bucks
commit: 85223d609c99eaa07cc598632b426cb33753526f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark