2023-06-23 20:33:04

by Andrew Davis

[permalink] [raw]
Subject: [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example

The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon
compatible hint. Remove the same from the example in this binding.

Signed-off-by: Andrew Davis <[email protected]>
---
.../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
index 0c98d913747bb..e6289fbe69070 100644
--- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
@@ -101,7 +101,7 @@ examples:
};

clock-controller@4140 {
- compatible = "ti,am654-ehrpwm-tbclk", "syscon";
+ compatible = "ti,am654-ehrpwm-tbclk";
reg = <0x4140 0x18>;
#clock-cells = <1>;
};
--
2.39.2



2023-06-23 21:05:10

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example

On Fri, Jun 23, 2023 at 2:15 PM Andrew Davis <[email protected]> wrote:
>
> The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon
> compatible hint. Remove the same from the example in this binding.
>
> Signed-off-by: Andrew Davis <[email protected]>
> ---
> .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for the quick fix.

Acked-by: Rob Herring <[email protected]>

Stephen should apply this.

Rob

2023-06-23 21:43:22

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example


On Fri, 23 Jun 2023 15:15:19 -0500, Andrew Davis wrote:
> The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon
> compatible hint. Remove the same from the example in this binding.
>
> Signed-off-by: Andrew Davis <[email protected]>
> ---
> .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: scm-conf@100000: clock-controller@4140:compatible: ['ti,am654-ehrpwm-tbclk'] is too short
from schema $id: http://devicetree.org/schemas/mfd/ti,j721e-system-controller.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.example.dtb: clock-controller@4140: compatible: ['ti,am654-ehrpwm-tbclk'] is too short
from schema $id: http://devicetree.org/schemas/clock/ti,am654-ehrpwm-tbclk.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


2023-06-27 00:14:27

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mfd: ti,j721e-system-controller: Remove syscon from example

Quoting Andrew Davis (2023-06-23 13:15:19)
> The binding for ti,am654-ehrpwm-tbclk was updated to remove the syscon
> compatible hint. Remove the same from the example in this binding.
>
> Signed-off-by: Andrew Davis <[email protected]>
> ---

Applied to clk-next