2022-12-07 21:43:20

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: sc7280: Fix CPU nodes compatible string

'arm,kryo' is not documented and is not an Arm Ltd thing either as that
is Qualcomm branding. The correct compatible is 'qcom,kryo'.

Signed-off-by: Rob Herring <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 212580316d3e..f06cc7588acc 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -166,7 +166,7 @@ cpus {

CPU0: cpu@0 {
device_type = "cpu";
- compatible = "arm,kryo";
+ compatible = "qcom,kryo";
reg = <0x0 0x0>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
@@ -189,7 +189,7 @@ L3_0: l3-cache {

CPU1: cpu@100 {
device_type = "cpu";
- compatible = "arm,kryo";
+ compatible = "qcom,kryo";
reg = <0x0 0x100>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
@@ -209,7 +209,7 @@ L2_100: l2-cache {

CPU2: cpu@200 {
device_type = "cpu";
- compatible = "arm,kryo";
+ compatible = "qcom,kryo";
reg = <0x0 0x200>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
@@ -229,7 +229,7 @@ L2_200: l2-cache {

CPU3: cpu@300 {
device_type = "cpu";
- compatible = "arm,kryo";
+ compatible = "qcom,kryo";
reg = <0x0 0x300>;
enable-method = "psci";
cpu-idle-states = <&LITTLE_CPU_SLEEP_0
@@ -249,7 +249,7 @@ L2_300: l2-cache {

CPU4: cpu@400 {
device_type = "cpu";
- compatible = "arm,kryo";
+ compatible = "qcom,kryo";
reg = <0x0 0x400>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
@@ -269,7 +269,7 @@ L2_400: l2-cache {

CPU5: cpu@500 {
device_type = "cpu";
- compatible = "arm,kryo";
+ compatible = "qcom,kryo";
reg = <0x0 0x500>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
@@ -289,7 +289,7 @@ L2_500: l2-cache {

CPU6: cpu@600 {
device_type = "cpu";
- compatible = "arm,kryo";
+ compatible = "qcom,kryo";
reg = <0x0 0x600>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
@@ -309,7 +309,7 @@ L2_600: l2-cache {

CPU7: cpu@700 {
device_type = "cpu";
- compatible = "arm,kryo";
+ compatible = "qcom,kryo";
reg = <0x0 0x700>;
enable-method = "psci";
cpu-idle-states = <&BIG_CPU_SLEEP_0
--
2.35.1


2023-01-03 20:18:15

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Fix CPU nodes compatible string

On Wed, Dec 7, 2022 at 3:13 PM Rob Herring <[email protected]> wrote:
>
> 'arm,kryo' is not documented and is not an Arm Ltd thing either as that
> is Qualcomm branding. The correct compatible is 'qcom,kryo'.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280.dtsi | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)

Ping!

>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 212580316d3e..f06cc7588acc 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -166,7 +166,7 @@ cpus {
>
> CPU0: cpu@0 {
> device_type = "cpu";
> - compatible = "arm,kryo";
> + compatible = "qcom,kryo";
> reg = <0x0 0x0>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> @@ -189,7 +189,7 @@ L3_0: l3-cache {
>
> CPU1: cpu@100 {
> device_type = "cpu";
> - compatible = "arm,kryo";
> + compatible = "qcom,kryo";
> reg = <0x0 0x100>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> @@ -209,7 +209,7 @@ L2_100: l2-cache {
>
> CPU2: cpu@200 {
> device_type = "cpu";
> - compatible = "arm,kryo";
> + compatible = "qcom,kryo";
> reg = <0x0 0x200>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> @@ -229,7 +229,7 @@ L2_200: l2-cache {
>
> CPU3: cpu@300 {
> device_type = "cpu";
> - compatible = "arm,kryo";
> + compatible = "qcom,kryo";
> reg = <0x0 0x300>;
> enable-method = "psci";
> cpu-idle-states = <&LITTLE_CPU_SLEEP_0
> @@ -249,7 +249,7 @@ L2_300: l2-cache {
>
> CPU4: cpu@400 {
> device_type = "cpu";
> - compatible = "arm,kryo";
> + compatible = "qcom,kryo";
> reg = <0x0 0x400>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> @@ -269,7 +269,7 @@ L2_400: l2-cache {
>
> CPU5: cpu@500 {
> device_type = "cpu";
> - compatible = "arm,kryo";
> + compatible = "qcom,kryo";
> reg = <0x0 0x500>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> @@ -289,7 +289,7 @@ L2_500: l2-cache {
>
> CPU6: cpu@600 {
> device_type = "cpu";
> - compatible = "arm,kryo";
> + compatible = "qcom,kryo";
> reg = <0x0 0x600>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> @@ -309,7 +309,7 @@ L2_600: l2-cache {
>
> CPU7: cpu@700 {
> device_type = "cpu";
> - compatible = "arm,kryo";
> + compatible = "qcom,kryo";
> reg = <0x0 0x700>;
> enable-method = "psci";
> cpu-idle-states = <&BIG_CPU_SLEEP_0
> --
> 2.35.1
>

2023-01-11 06:01:46

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Fix CPU nodes compatible string

On Wed, 7 Dec 2022 15:13:27 -0600, Rob Herring wrote:
> 'arm,kryo' is not documented and is not an Arm Ltd thing either as that
> is Qualcomm branding. The correct compatible is 'qcom,kryo'.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sc7280: Fix CPU nodes compatible string
commit: 9293c3e85a200d3a453ca208548d5dfc9d1af70a

Best regards,
--
Bjorn Andersson <[email protected]>