2024-04-02 20:24:30

by Rob Herring

[permalink] [raw]
Subject: [PATCH] dt-bindings: mfd: syscon: Add missing simple syscon compatibles

Add various "simple" syscon compatibles which were undocumented or
still documented with old text bindings.

apm,xgene-csw, apm,xgene-efuse, apm,xgene-mcb, apm,xgene-rb,
fsl,ls1088a-reset, marvell,armada-3700-cpu-misc,
mediatek,mt2712-pctl-a-syscfg, mediatek,mt6397-pctl-pmic-syscfg, and
mediatek,mt8173-pctl-a-syscfg were all undocumented, but are in use
already. Remove the old text binding docs for the others.

Signed-off-by: Rob Herring <[email protected]>
---
.../arm/altera/socfpga-sdram-controller.txt | 12 -------
.../devicetree/bindings/arm/apm/scu.txt | 17 ----------
.../bindings/arm/marvell/armada-37xx.txt | 32 -------------------
.../bindings/mfd/brcm,iproc-cdru.txt | 16 ----------
.../bindings/mfd/brcm,iproc-mhb.txt | 18 -----------
.../devicetree/bindings/mfd/syscon.yaml | 15 +++++++++
6 files changed, 15 insertions(+), 95 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt
delete mode 100644 Documentation/devicetree/bindings/arm/apm/scu.txt
delete mode 100644 Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
delete mode 100644 Documentation/devicetree/bindings/mfd/brcm,iproc-cdru.txt
delete mode 100644 Documentation/devicetree/bindings/mfd/brcm,iproc-mhb.txt

diff --git a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt b/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt
deleted file mode 100644
index 77ca635765e1..000000000000
--- a/Documentation/devicetree/bindings/arm/altera/socfpga-sdram-controller.txt
+++ /dev/null
@@ -1,12 +0,0 @@
-Altera SOCFPGA SDRAM Controller
-
-Required properties:
-- compatible : Should contain "altr,sdr-ctl" and "syscon".
- syscon is required by the Altera SOCFPGA SDRAM EDAC.
-- reg : Should contain 1 register range (address and length)
-
-Example:
- sdr: sdr@ffc25000 {
- compatible = "altr,sdr-ctl", "syscon";
- reg = <0xffc25000 0x1000>;
- };
diff --git a/Documentation/devicetree/bindings/arm/apm/scu.txt b/Documentation/devicetree/bindings/arm/apm/scu.txt
deleted file mode 100644
index b45be06625fd..000000000000
--- a/Documentation/devicetree/bindings/arm/apm/scu.txt
+++ /dev/null
@@ -1,17 +0,0 @@
-APM X-GENE SoC series SCU Registers
-
-This system clock unit contain various register that control block resets,
-clock enable/disables, clock divisors and other deepsleep registers.
-
-Properties:
- - compatible : should contain two values. First value must be:
- - "apm,xgene-scu"
- second value must be always "syscon".
-
- - reg : offset and length of the register set.
-
-Example :
- scu: system-clk-controller@17000000 {
- compatible = "apm,xgene-scu","syscon";
- reg = <0x0 0x17000000 0x0 0x400>;
- };
diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt b/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
deleted file mode 100644
index 29fa93dad52b..000000000000
--- a/Documentation/devicetree/bindings/arm/marvell/armada-37xx.txt
+++ /dev/null
@@ -1,32 +0,0 @@
-Power management
-----------------
-
-For power management (particularly DVFS and AVS), the North Bridge
-Power Management component is needed:
-
-Required properties:
-- compatible : should contain "marvell,armada-3700-nb-pm", "syscon";
-- reg : the register start and length for the North Bridge
- Power Management
-
-Example:
-
-nb_pm: syscon@14000 {
- compatible = "marvell,armada-3700-nb-pm", "syscon";
- reg = <0x14000 0x60>;
-}
-
-AVS
----
-
-For AVS an other component is needed:
-
-Required properties:
-- compatible : should contain "marvell,armada-3700-avs", "syscon";
-- reg : the register start and length for the AVS
-
-Example:
-avs: avs@11500 {
- compatible = "marvell,armada-3700-avs", "syscon";
- reg = <0x11500 0x40>;
-}
diff --git a/Documentation/devicetree/bindings/mfd/brcm,iproc-cdru.txt b/Documentation/devicetree/bindings/mfd/brcm,iproc-cdru.txt
deleted file mode 100644
index 82f82e069563..000000000000
--- a/Documentation/devicetree/bindings/mfd/brcm,iproc-cdru.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-Broadcom iProc Chip Device Resource Unit (CDRU)
-
-Various Broadcom iProc SoCs have a set of registers that provide various
-chip specific device and resource configurations. This node allows access to
-these CDRU registers via syscon.
-
-Required properties:
-- compatible: should contain:
- "brcm,sr-cdru", "syscon" for Stingray
-- reg: base address and range of the CDRU registers
-
-Example:
- cdru: syscon@6641d000 {
- compatible = "brcm,sr-cdru", "syscon";
- reg = <0 0x6641d000 0 0x400>;
- };
diff --git a/Documentation/devicetree/bindings/mfd/brcm,iproc-mhb.txt b/Documentation/devicetree/bindings/mfd/brcm,iproc-mhb.txt
deleted file mode 100644
index 4421e9771b8a..000000000000
--- a/Documentation/devicetree/bindings/mfd/brcm,iproc-mhb.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-Broadcom iProc Multi Host Bridge (MHB)
-
-Certain Broadcom iProc SoCs have a multi host bridge (MHB) block that controls
-the connection and configuration of 1) internal PCIe serdes; 2) PCIe endpoint
-interface; 3) access to the Nitro (network processing) engine
-
-This node allows access to these MHB registers via syscon.
-
-Required properties:
-- compatible: should contain:
- "brcm,sr-mhb", "syscon" for Stingray
-- reg: base address and range of the MHB registers
-
-Example:
- mhb: syscon@60401000 {
- compatible = "brcm,sr-mhb", "syscon";
- reg = <0 0x60401000 0 0x38c>;
- };
diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 9d55bee155ce..0327e779e327 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -38,11 +38,20 @@ properties:
- allwinner,sun8i-h3-system-controller
- allwinner,sun8i-v3s-system-controller
- allwinner,sun50i-a64-system-controller
+ - altr,sdr-ctl
- amd,pensando-elba-syscon
+ - apm,xgene-csw
+ - apm,xgene-efuse
+ - apm,xgene-mcb
+ - apm,xgene-rb
+ - apm,xgene-scu
- brcm,cru-clkset
+ - brcm,sr-cdru
+ - brcm,sr-mhb
- freecom,fsg-cs2-system-controller
- fsl,imx93-aonmix-ns-syscfg
- fsl,imx93-wakeupmix-syscfg
+ - fsl,ls1088a-reset
- hisilicon,dsa-subctrl
- hisilicon,hi6220-sramctrl
- hisilicon,pcie-sas-subctrl
@@ -51,9 +60,15 @@ properties:
- intel,lgm-syscon
- loongson,ls1b-syscon
- loongson,ls1c-syscon
+ - marvell,armada-3700-cpu-misc
+ - marvell,armada-3700-nb-pm
+ - marvell,armada-3700-avs
- marvell,armada-3700-usb2-host-misc
+ - mediatek,mt2712-pctl-a-syscfg
+ - mediatek,mt6397-pctl-pmic-syscfg
- mediatek,mt8135-pctl-a-syscfg
- mediatek,mt8135-pctl-b-syscfg
+ - mediatek,mt8173-pctl-a-syscfg
- mediatek,mt8365-syscfg
- microchip,lan966x-cpu-syscon
- microchip,sparx5-cpu-syscon
--
2.43.0



2024-04-03 07:07:44

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: mfd: syscon: Add missing simple syscon compatibles

On 02/04/2024 22:24, Rob Herring wrote:
> Add various "simple" syscon compatibles which were undocumented or
> still documented with old text bindings.
>
> apm,xgene-csw, apm,xgene-efuse, apm,xgene-mcb, apm,xgene-rb,
> fsl,ls1088a-reset, marvell,armada-3700-cpu-misc,
> mediatek,mt2712-pctl-a-syscfg, mediatek,mt6397-pctl-pmic-syscfg, and
> mediatek,mt8173-pctl-a-syscfg were all undocumented, but are in use
> already. Remove the old text binding docs for the others.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof


2024-04-11 12:50:39

by Lee Jones

[permalink] [raw]
Subject: Re: (subset) [PATCH] dt-bindings: mfd: syscon: Add missing simple syscon compatibles

On Tue, 02 Apr 2024 15:24:11 -0500, Rob Herring wrote:
> Add various "simple" syscon compatibles which were undocumented or
> still documented with old text bindings.
>
> apm,xgene-csw, apm,xgene-efuse, apm,xgene-mcb, apm,xgene-rb,
> fsl,ls1088a-reset, marvell,armada-3700-cpu-misc,
> mediatek,mt2712-pctl-a-syscfg, mediatek,mt6397-pctl-pmic-syscfg, and
> mediatek,mt8173-pctl-a-syscfg were all undocumented, but are in use
> already. Remove the old text binding docs for the others.
>
> [...]

Applied, thanks!

[1/1] dt-bindings: mfd: syscon: Add missing simple syscon compatibles
commit: 9f43ae67db2a3d85cf2b5eebc3b54c8891200b5c

--
Lee Jones [李琼斯]


2024-04-11 14:29:39

by Rob Herring

[permalink] [raw]
Subject: Re: (subset) [PATCH] dt-bindings: mfd: syscon: Add missing simple syscon compatibles

On Thu, Apr 11, 2024 at 7:50 AM Lee Jones <[email protected]> wrote:
>
> On Tue, 02 Apr 2024 15:24:11 -0500, Rob Herring wrote:
> > Add various "simple" syscon compatibles which were undocumented or
> > still documented with old text bindings.
> >
> > apm,xgene-csw, apm,xgene-efuse, apm,xgene-mcb, apm,xgene-rb,
> > fsl,ls1088a-reset, marvell,armada-3700-cpu-misc,
> > mediatek,mt2712-pctl-a-syscfg, mediatek,mt6397-pctl-pmic-syscfg, and
> > mediatek,mt8173-pctl-a-syscfg were all undocumented, but are in use
> > already. Remove the old text binding docs for the others.
> >
> > [...]
>
> Applied, thanks!

Note that something is going haywire with b4 or you applied a subset
of a single patch... I really wish b4 didn't change the subjects at
all since Gmail is incapable of following standard threading.

>
> [1/1] dt-bindings: mfd: syscon: Add missing simple syscon compatibles
> commit: 9f43ae67db2a3d85cf2b5eebc3b54c8891200b5c
>
> --
> Lee Jones [李琼斯]
>

2024-04-11 15:09:44

by Lee Jones

[permalink] [raw]
Subject: Re: (subset) [PATCH] dt-bindings: mfd: syscon: Add missing simple syscon compatibles

[email protected]

On Thu, 11 Apr 2024, Rob Herring wrote:

> On Thu, Apr 11, 2024 at 7:50 AM Lee Jones <[email protected]> wrote:
> >
> > On Tue, 02 Apr 2024 15:24:11 -0500, Rob Herring wrote:
> > > Add various "simple" syscon compatibles which were undocumented or
> > > still documented with old text bindings.
> > >
> > > apm,xgene-csw, apm,xgene-efuse, apm,xgene-mcb, apm,xgene-rb,
> > > fsl,ls1088a-reset, marvell,armada-3700-cpu-misc,
> > > mediatek,mt2712-pctl-a-syscfg, mediatek,mt6397-pctl-pmic-syscfg, and
> > > mediatek,mt8173-pctl-a-syscfg were all undocumented, but are in use
> > > already. Remove the old text binding docs for the others.
> > >
> > > [...]
> >
> > Applied, thanks!
>
> Note that something is going haywire with b4 or you applied a subset
> of a single patch... I really wish b4 didn't change the subjects at
> all since Gmail is incapable of following standard threading.

I think "haywire" is a bit drastic. :)

It's to do with the way I fetch patches from the list:

b4 am -3 -slt ${PATCHES} -o - ${id} > ${MBOX}

Where ${PATCHES}:

if [ "${RANGE}" != "" ]; then
PATCHES="-P ${RANGE}"
elif [ "${SET}" == "" ]; then
PATCHES="-P _" # We need this to pluck patches from sets
fi

`-P _` means cherry-pick, which doesn't appear to know whether we're
picking up an entire set containing only a single patch or pulling out
an individual patch from a larger set.

There is an option to add a new Mutt key binding to do it which drops
the `-P _` part in the former case, but I've ran out of free keys!

Present Mutt bindings for kernel maintenance:

macro index,pager M '<pipe-entry>~/bin/apply-patch.sh mfd-next<enter>'
macro index,pager F '<pipe-entry>~/bin/apply-patch.sh mfd-fixes<enter>'
macro index,pager B '<pipe-entry>~/bin/apply-patch.sh backlight-next<enter>'
macro index,pager L '<pipe-entry>~/bin/apply-patch.sh leds-next<enter>'
macro index,pager T '<pipe-entry>~/bin/apply-patch.sh toys<enter>'
- These all apply single patches (single submissions or cherry-picks from sets)

macro index,pager S '<pipe-entry>~/bin/apply-patch.sh set<enter>'
- This presents a menu of kernel repos, then applies the whole set to ${choice}

macro index,pager R '<pipe-entry>~/bin/apply-patch.sh range<enter>'
- This presents a prompt to enter a given range (e.g. 1-3,6,8)
- Followed by a menu of kernel repos, then applies the range to ${choice}

macro index,pager A '<copy-message>=patches-to-apply<enter><enter>'
- Manually applies patches from a mail folder (does not use b4)

--
Lee Jones [李琼斯]