Define the vendor prefix for InfoVision Optoelectronics and add their
M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
of panel-simple.
Signed-off-by: Bjorn Andersson <[email protected]>
---
Changes since v1:
- Added this patch
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
2 files changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index daf86ba18f47..31dc88f5b2a9 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -129,6 +129,8 @@ properties:
- hannstar,hsd100pxn1
# Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel
- hit,tx23d38vm0caa
+ # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
+ - ivo,m133nwf4-r0
# Innolux AT043TN24 4.3" WQVGA TFT LCD panel
- innolux,at043tn24
# Innolux AT070TN92 7.0" WQVGA TFT LCD panel
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index d3891386d671..31012f91fb9a 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -463,6 +463,8 @@ patternProperties:
description: Infineon Technologies
"^inforce,.*":
description: Inforce Computing
+ "^ivo,.*":
+ description: InfoVision Optoelectronics Kunshan Co. Ltd.
"^ingenic,.*":
description: Ingenic Semiconductor
"^innolux,.*":
--
2.26.0
The InfoVision Optoelectronics M133NWF4 R0 panel is a 13.3" 1920x1080
eDP panel, add support for it in panel-simple.
Signed-off-by: Bjorn Andersson <[email protected]>
---
Changes since v1:
- Specified bus_format, bus_flags and connector_type
drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 5b92583bccdf..50ee1b842748 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2010,6 +2010,37 @@ static const struct panel_desc innolux_zj070na_01p = {
},
};
+static const struct drm_display_mode ivo_m133nwf4_r0_mode = {
+ .clock = 138778,
+ .hdisplay = 1920,
+ .hsync_start = 1920 + 24,
+ .hsync_end = 1920 + 24 + 48,
+ .htotal = 1920 + 24 + 48 + 88,
+ .vdisplay = 1080,
+ .vsync_start = 1080 + 3,
+ .vsync_end = 1080 + 3 + 12,
+ .vtotal = 1080 + 3 + 12 + 17,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc ivo_m133nwf4_r0 = {
+ .modes = &ivo_m133nwf4_r0_mode,
+ .num_modes = 1,
+ .bpc = 8,
+ .size = {
+ .width = 294,
+ .height = 165,
+ },
+ .delay = {
+ .hpd_absent_delay = 200,
+ .unprepare = 500,
+ },
+ .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+ .bus_flags = DRM_BUS_FLAG_DATA_MSB_TO_LSB,
+ .connector_type = DRM_MODE_CONNECTOR_eDP,
+};
+
static const struct display_timing koe_tx14d24vm1bpa_timing = {
.pixelclock = { 5580000, 5850000, 6200000 },
.hactive = { 320, 320, 320 },
@@ -3619,6 +3650,9 @@ static const struct of_device_id platform_of_match[] = {
}, {
.compatible = "innolux,zj070na-01p",
.data = &innolux_zj070na_01p,
+ }, {
+ .compatible = "ivo,m133nwf4-r0",
+ .data = &ivo_m133nwf4_r0,
}, {
.compatible = "koe,tx14d24vm1bpa",
.data = &koe_tx14d24vm1bpa,
--
2.26.0
Hi Bj?rn.
On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> Define the vendor prefix for InfoVision Optoelectronics and add their
> M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
> of panel-simple.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
I got OK for the vendor prefix on irc so patch is now added to
drm-misc-next.
Another time please use a dedicated patch for vendor-prefix
so it is not hidden with other stuff. This way the chance
to get the attention of the right people is better.
Also added the panel-simple patch.
Both pushed out now.
Sam
> ---
>
> Changes since v1:
> - Added this patch
>
> .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++
> Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index daf86ba18f47..31dc88f5b2a9 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -129,6 +129,8 @@ properties:
> - hannstar,hsd100pxn1
> # Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel
> - hit,tx23d38vm0caa
> + # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
> + - ivo,m133nwf4-r0
> # Innolux AT043TN24 4.3" WQVGA TFT LCD panel
> - innolux,at043tn24
> # Innolux AT070TN92 7.0" WQVGA TFT LCD panel
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index d3891386d671..31012f91fb9a 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -463,6 +463,8 @@ patternProperties:
> description: Infineon Technologies
> "^inforce,.*":
> description: Inforce Computing
> + "^ivo,.*":
> + description: InfoVision Optoelectronics Kunshan Co. Ltd.
> "^ingenic,.*":
> description: Ingenic Semiconductor
> "^innolux,.*":
> --
> 2.26.0
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg <[email protected]> wrote:
>
> Hi Björn.
>
> On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> > Define the vendor prefix for InfoVision Optoelectronics and add their
> > M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
> > of panel-simple.
> >
> > Signed-off-by: Bjorn Andersson <[email protected]>
>
> I got OK for the vendor prefix on irc so patch is now added to
> drm-misc-next.
> Another time please use a dedicated patch for vendor-prefix
> so it is not hidden with other stuff. This way the chance
> to get the attention of the right people is better.
I should have mentioned there's basically one thing to check:
alphabetical order.
The good news is both files got it wrong, so at least we're consistent. :)
Rob
Hi Rob.
On Tue, Apr 28, 2020 at 09:27:51AM -0500, Rob Herring wrote:
> On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg <[email protected]> wrote:
> >
> > Hi Bj?rn.
> >
> > On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> > > Define the vendor prefix for InfoVision Optoelectronics and add their
> > > M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
> > > of panel-simple.
> > >
> > > Signed-off-by: Bjorn Andersson <[email protected]>
> >
> > I got OK for the vendor prefix on irc so patch is now added to
> > drm-misc-next.
> > Another time please use a dedicated patch for vendor-prefix
> > so it is not hidden with other stuff. This way the chance
> > to get the attention of the right people is better.
>
> I should have mentioned there's basically one thing to check:
> alphabetical order.
I thought I checked that, but obviously not - hrmpf..
I will post a follow-up patch for drm-misc-next to fix it.
Sam
On Tue 28 Apr 10:05 PDT 2020, Sam Ravnborg wrote:
> Hi Rob.
>
> On Tue, Apr 28, 2020 at 09:27:51AM -0500, Rob Herring wrote:
> > On Sat, Apr 25, 2020 at 12:58 PM Sam Ravnborg <[email protected]> wrote:
> > >
> > > Hi Bj?rn.
> > >
> > > On Mon, Apr 20, 2020 at 02:57:27PM -0700, Bjorn Andersson wrote:
> > > > Define the vendor prefix for InfoVision Optoelectronics and add their
> > > > M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel to the compatible list
> > > > of panel-simple.
> > > >
> > > > Signed-off-by: Bjorn Andersson <[email protected]>
> > >
> > > I got OK for the vendor prefix on irc so patch is now added to
> > > drm-misc-next.
> > > Another time please use a dedicated patch for vendor-prefix
> > > so it is not hidden with other stuff. This way the chance
> > > to get the attention of the right people is better.
> >
> > I should have mentioned there's basically one thing to check:
> > alphabetical order.
> I thought I checked that, but obviously not - hrmpf..
Sorry about that, I thought I did double check that before posting it...
> I will post a follow-up patch for drm-misc-next to fix it.
>
Thank you,
Bjorn