2015-08-26 00:04:08

by Dmitry Torokhov

[permalink] [raw]
Subject: [PATCH] of/irq: export of_get_irq_byname()

Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
can be compiled as a module (such as I2C) it can have access to the symbol.

Reported-by: Stephen Rothwell <[email protected]>
Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
---
drivers/of/irq.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 7ef837e..1a7911d 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -446,6 +446,7 @@ int of_irq_get_byname(struct device_node *dev, const char *name)

return of_irq_get(dev, index);
}
+EXPORT_SYMBOL_GPL(of_irq_get_byname);

/**
* of_irq_count - Count the number of IRQs a node uses
--
2.5.0.457.gab17608


--
Dmitry


2015-08-26 00:24:29

by Stephen Rothwell

[permalink] [raw]
Subject: Re: [PATCH] of/irq: export of_get_irq_byname()

Hi Dmitry,

On Tue, 25 Aug 2015 17:04:02 -0700 Dmitry Torokhov <[email protected]> wrote:
>
> Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
> can be compiled as a module (such as I2C) it can have access to the symbol.
>
> Reported-by: Stephen Rothwell <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Dmitry Torokhov <[email protected]>

I applied that to linux-next today. Pelase get it applied to the i2c
tree (with appropriate acks).

--
Cheers,
Stephen Rothwell [email protected]

2015-08-26 07:40:32

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] of/irq: export of_get_irq_byname()

On Wed, Aug 26, 2015 at 10:24:25AM +1000, Stephen Rothwell wrote:
> Hi Dmitry,
>
> On Tue, 25 Aug 2015 17:04:02 -0700 Dmitry Torokhov <[email protected]> wrote:
> >
> > Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
> > can be compiled as a module (such as I2C) it can have access to the symbol.
> >
> > Reported-by: Stephen Rothwell <[email protected]>
> > Reported-by: kbuild test robot <[email protected]>
> > Signed-off-by: Dmitry Torokhov <[email protected]>
>
> I applied that to linux-next today. Pelase get it applied to the i2c
> tree (with appropriate acks).

Waiting for Rob's Ack, then I'll pick it up...


Attachments:
(No filename) (677.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments

2015-08-26 13:16:34

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] of/irq: export of_get_irq_byname()

On Tue, Aug 25, 2015 at 7:04 PM, Dmitry Torokhov
<[email protected]> wrote:
> Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
> can be compiled as a module (such as I2C) it can have access to the symbol.
>
> Reported-by: Stephen Rothwell <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Dmitry Torokhov <[email protected]>

Acked-by: Rob Herring <[email protected]>

> ---
> drivers/of/irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index 7ef837e..1a7911d 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -446,6 +446,7 @@ int of_irq_get_byname(struct device_node *dev, const char *name)
>
> return of_irq_get(dev, index);
> }
> +EXPORT_SYMBOL_GPL(of_irq_get_byname);
>
> /**
> * of_irq_count - Count the number of IRQs a node uses
> --
> 2.5.0.457.gab17608
>
>
> --
> Dmitry

2015-08-26 16:37:00

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH] of/irq: export of_get_irq_byname()

On Tue, Aug 25, 2015 at 05:04:02PM -0700, Dmitry Torokhov wrote:
> Similarly to of_get_irq(), let's export of_irq_get_byname(), so if a bus core
> can be compiled as a module (such as I2C) it can have access to the symbol.
>
> Reported-by: Stephen Rothwell <[email protected]>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Dmitry Torokhov <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (431.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments