2019-08-13 18:40:08

by Stephen Boyd

[permalink] [raw]
Subject: [PATCH] devicetree: Expose dtbs_check and dt_binding_check some more

It wasn't obvious that this was a command to run based on 'make help',
so add it to the top-level help for devicetree builds. Also, add an
example to the documentation to show that db_binding_check can be run
with DT_SCHEMA_FILES= to only check one schema file instead of all of
them.

Cc: Masahiro Yamada <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Cc: <[email protected]>
Signed-off-by: Stephen Boyd <[email protected]>
---

I didn't find this sent, so sending again!

Documentation/devicetree/writing-schema.md | 1 +
Makefile | 6 ++++--
2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/writing-schema.md b/Documentation/devicetree/writing-schema.md
index dc032db36262..17ad67887fde 100644
--- a/Documentation/devicetree/writing-schema.md
+++ b/Documentation/devicetree/writing-schema.md
@@ -120,6 +120,7 @@ This will first run the `dt_binding_check` which generates the processed schema.
It is also possible to run checks with a single schema file by setting the
'DT_SCHEMA_FILES' variable to a specific schema file.

+`make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml`
`make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/trivial-devices.yaml`


diff --git a/Makefile b/Makefile
index 9be5834073f8..96bb28aa1c46 100644
--- a/Makefile
+++ b/Makefile
@@ -1503,8 +1503,10 @@ help:
@echo ''
@$(if $(dtstree), \
echo 'Devicetree:'; \
- echo '* dtbs - Build device tree blobs for enabled boards'; \
- echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \
+ echo '* dtbs - Build device tree blobs for enabled boards'; \
+ echo ' dtbs_install - Install dtbs to $(INSTALL_DTBS_PATH)'; \
+ echo ' dt_binding_check - Validate device tree binding documents'; \
+ echo ' dtbs_check - Validate device tree source files';\
echo '')

@echo 'Userspace tools targets:'
--
Sent by a computer through tubes


2019-08-13 22:33:59

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] devicetree: Expose dtbs_check and dt_binding_check some more

On Tue, Aug 13, 2019 at 12:38 PM Stephen Boyd <[email protected]> wrote:
>
> It wasn't obvious that this was a command to run based on 'make help',
> so add it to the top-level help for devicetree builds. Also, add an
> example to the documentation to show that db_binding_check can be run
> with DT_SCHEMA_FILES= to only check one schema file instead of all of
> them.
>
> Cc: Masahiro Yamada <[email protected]>
> Cc: <[email protected]>
> Cc: <[email protected]>
> Cc: <[email protected]>
> Signed-off-by: Stephen Boyd <[email protected]>
> ---
>
> I didn't find this sent, so sending again!

You had. :)

>
> Documentation/devicetree/writing-schema.md | 1 +
> Makefile | 6 ++++--
> 2 files changed, 5 insertions(+), 2 deletions(-)

writing-schema.md got converted to rst, so I fixed up and applied.

Rob

2019-08-13 22:45:29

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] devicetree: Expose dtbs_check and dt_binding_check some more

Quoting Rob Herring (2019-08-13 15:32:48)
> On Tue, Aug 13, 2019 at 12:38 PM Stephen Boyd <[email protected]> wrote:
> >
> > It wasn't obvious that this was a command to run based on 'make help',
> > so add it to the top-level help for devicetree builds. Also, add an
> > example to the documentation to show that db_binding_check can be run
> > with DT_SCHEMA_FILES= to only check one schema file instead of all of
> > them.
> >
> > Cc: Masahiro Yamada <[email protected]>
> > Cc: <[email protected]>
> > Cc: <[email protected]>
> > Cc: <[email protected]>
> > Signed-off-by: Stephen Boyd <[email protected]>
> > ---
> >
> > I didn't find this sent, so sending again!
>
> You had. :)

Oh no, sorry! :(

>
> >
> > Documentation/devicetree/writing-schema.md | 1 +
> > Makefile | 6 ++++--
> > 2 files changed, 5 insertions(+), 2 deletions(-)
>
> writing-schema.md got converted to rst, so I fixed up and applied.

Thanks!