Add common fan properties bindings to a schema.
Bindings for fan controllers can reference the common schema for the
fan
child nodes:
patternProperties:
"^fan@[0-2]":
type: object
allOf:
- $ref: fan-common.yaml#
Signed-off-by: Naresh Solanki <[email protected]>
---
.../devicetree/bindings/hwmon/fan-common.yaml | 80 +++++++++++++++++++
1 file changed, 80 insertions(+)
create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
new file mode 100644
index 000000000000..abc8375da646
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
@@ -0,0 +1,80 @@
+# SPDX-License-Identifier: GPL-2.0-only
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Common fan properties
+
+maintainers:
+ - Naresh Solanki <[email protected]>
+
+properties:
+ max-rpm:
+ description:
+ Max RPM supported by fan
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ pulse-per-revolution:
+ description:
+ The number of pulse from fan sensor per revolution.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ target-rpm:
+ description:
+ Target RPM the fan should be configured during driver probe.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ pwm-frequency:
+ description:
+ PWM frequency for fan.
+ $ref: /schemas/types.yaml#/definitions/uint32
+
+ pwm-polarity-inverse:
+ description:
+ PWM polarity for fan.
+ type: boolean
+
+ label:
+ description:
+ Optional fan label
+ $ref: /schemas/types.yaml#/definitions/string
+
+additionalProperties: true
+
+examples:
+ - |
+
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ fan-controller@30 {
+ compatible = "maxim,max6639";
+ reg = <0x30>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ fan@0 {
+ reg = <0>;
+ label = "CPU0_Fan";
+ max-rpm = <32000>;
+ pulse-per-revolution = <2>;
+ target-rpm = <2000>;
+ pwm-frequency = <25000>;
+ };
+
+ fan@1 {
+ reg = <1>;
+ label = "PCIe0_Fan";
+ max-rpm = <32000>;
+ pulse-per-revolution = <2>;
+ target-rpm = <2000>;
+ pwm-frequency = <25000>;
+ };
+
+ };
+ };
+
+...
base-commit: 0cf46a653bdae56683fece68dc50340f7520e6c4
--
2.37.3
On 10/11/22 03:47, Naresh Solanki wrote:
> Add common fan properties bindings to a schema.
>
> Bindings for fan controllers can reference the common schema for the
> fan
>
> child nodes:
>
> patternProperties:
> "^fan@[0-2]":
> type: object
> allOf:
> - $ref: fan-common.yaml#
>
> Signed-off-by: Naresh Solanki <[email protected]>
> ---
> .../devicetree/bindings/hwmon/fan-common.yaml | 80 +++++++++++++++++++
> 1 file changed, 80 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> new file mode 100644
> index 000000000000..abc8375da646
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common fan properties
> +
> +maintainers:
> + - Naresh Solanki <[email protected]>
> +
> +properties:
> + max-rpm:
> + description:
> + Max RPM supported by fan
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pulse-per-revolution:
> + description:
> + The number of pulse from fan sensor per revolution.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + target-rpm:
> + description:
> + Target RPM the fan should be configured during driver probe.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pwm-frequency:
> + description:
> + PWM frequency for fan.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pwm-polarity-inverse:
> + description:
> + PWM polarity for fan.
> + type: boolean
> +
> + label:
> + description:
> + Optional fan label
> + $ref: /schemas/types.yaml#/definitions/string
> +
Same question as before:
How are additional common bindings, such as min-rpm or fan-divider
(also sometimes called fan-prescale) supposed to be handled ?
As additions to this schema, or individually in each driver needing/
using them ?
Thanks,
Guenter
On 11/10/2022 06:47, Naresh Solanki wrote:
> Add common fan properties bindings to a schema.
>
> Bindings for fan controllers can reference the common schema for the
> fan
>
> child nodes:
>
> patternProperties:
> "^fan@[0-2]":
> type: object
> allOf:
> - $ref: fan-common.yaml#
>
> Signed-off-by: Naresh Solanki <[email protected]>
> ---
> .../devicetree/bindings/hwmon/fan-common.yaml | 80 +++++++++++++++++++
> 1 file changed, 80 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> new file mode 100644
> index 000000000000..abc8375da646
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common fan properties
Is a fan a hardware monitoring device? Maybe this should not be called a
fan?
> +
> +maintainers:
> + - Naresh Solanki <[email protected]>
> +
> +properties:
> + max-rpm:
> + description:
> + Max RPM supported by fan
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pulse-per-revolution:
> + description:
> + The number of pulse from fan sensor per revolution.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + target-rpm:
> + description:
> + Target RPM the fan should be configured during driver probe.
I think target depends on conditions, e.g. it is rarely one target.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pwm-frequency:
> + description:
> + PWM frequency for fan.
> + $ref: /schemas/types.yaml#/definitions/uint32
Use common units, so -hz
However I wonder if frequency is appropriate here - I thought PWMs are
rather configured via duty cycles.
> +
> + pwm-polarity-inverse:
> + description:
> + PWM polarity for fan.
Rather: Inversed PWM polarity for the fan.
> + type: boolean
> +
> + label:
> + description:
> + Optional fan label
> + $ref: /schemas/types.yaml#/definitions/string
Ref is not needed, core brings it.
> +
> +additionalProperties: true
> +
> +examples:
> + - |
> +
> +
Drop unneeded empty lines.
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan-controller@30 {
> + compatible = "maxim,max6639";
> + reg = <0x30>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan@0 {
> + reg = <0>;
> + label = "CPU0_Fan";
> + max-rpm = <32000>;
> + pulse-per-revolution = <2>;
> + target-rpm = <2000>;
> + pwm-frequency = <25000>;
> + };
> +
> + fan@1 {
> + reg = <1>;
> + label = "PCIe0_Fan";
> + max-rpm = <32000>;
> + pulse-per-revolution = <2>;
> + target-rpm = <2000>;
> + pwm-frequency = <25000>;
> + };
> +
Drop unneeded empty lines.
> + };
> + };
> +
> +...
>
> base-commit: 0cf46a653bdae56683fece68dc50340f7520e6c4
Best regards,
Krzysztof
Hi Guenter,
fan-common is intended for fan properties. i.e., those derived from
fan datasheets.
For min-rpm, some fans have minimum non zero rpm like 1900rpm below which
the fan cannot run.
But not sure what the best approach is but for chip specific setting
it should be in
chip specific DT schema. Suggestion?
Regards,
Naresh Solanki
9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email: [email protected]
Mobile: +91 9538631477
Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Eray Basar
Datenschutzhinweise nach Art. 13 DSGVO
On Tue, 11 Oct 2022 at 20:30, Guenter Roeck <[email protected]> wrote:
>
> On 10/11/22 03:47, Naresh Solanki wrote:
> > Add common fan properties bindings to a schema.
> >
> > Bindings for fan controllers can reference the common schema for the
> > fan
> >
> > child nodes:
> >
> > patternProperties:
> > "^fan@[0-2]":
> > type: object
> > allOf:
> > - $ref: fan-common.yaml#
> >
> > Signed-off-by: Naresh Solanki <[email protected]>
> > ---
> > .../devicetree/bindings/hwmon/fan-common.yaml | 80 +++++++++++++++++++
> > 1 file changed, 80 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> > new file mode 100644
> > index 000000000000..abc8375da646
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> > @@ -0,0 +1,80 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Common fan properties
> > +
> > +maintainers:
> > + - Naresh Solanki <[email protected]>
> > +
> > +properties:
> > + max-rpm:
> > + description:
> > + Max RPM supported by fan
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + pulse-per-revolution:
> > + description:
> > + The number of pulse from fan sensor per revolution.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + target-rpm:
> > + description:
> > + Target RPM the fan should be configured during driver probe.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + pwm-frequency:
> > + description:
> > + PWM frequency for fan.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + pwm-polarity-inverse:
> > + description:
> > + PWM polarity for fan.
> > + type: boolean
> > +
> > + label:
> > + description:
> > + Optional fan label
> > + $ref: /schemas/types.yaml#/definitions/string
> > +
>
> Same question as before:
>
> How are additional common bindings, such as min-rpm or fan-divider
> (also sometimes called fan-prescale) supposed to be handled ?
> As additions to this schema, or individually in each driver needing/
> using them ?
>
> Thanks,
> Guenter
On 10/11/22 09:12, Naresh Solanki wrote:
> Hi Guenter,
>
> fan-common is intended for fan properties. i.e., those derived from
> fan datasheets.
> For min-rpm, some fans have minimum non zero rpm like 1900rpm below which
> the fan cannot run.
>
I would argue the properties are for fan controllers, not for fans.
Fans don't have or depend on specific pwm frequencies. Fan controllers
do. Fans don't have a configurable pwm polarity. Fan controllers do,
to match the hardware on a board. Fans don't have or rely on
a target rpm. That is a system property, configured into the
fan controller. And so on.
If this is for fans, we'll need another set of properties for
fan controllers. The driver for max6639, being a fan controller,
would need to implement those properties.
Also, as implemented in the MAX6639, max-rpm is the fan's
rpm range, not the actual rpm. Your implementation is just
confusing, including the example in the bindings. Valid values
should be what the chip accepts, not some random value.
Really, I don't understand where you are going with this.
Guenter
> But not sure what the best approach is but for chip specific setting
> it should be in
> chip specific DT schema. Suggestion?
>
> Regards,
> Naresh Solanki
>
>
>
> 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
> Email: [email protected]
> Mobile: +91 9538631477
>
> Sitz der Gesellschaft: Bochum
> Handelsregister: Amtsgericht Bochum, HRB 17519
> Geschäftsführung: Sebastian Deutsch, Eray Basar
>
> Datenschutzhinweise nach Art. 13 DSGVO
>
> On Tue, 11 Oct 2022 at 20:30, Guenter Roeck <[email protected]> wrote:
>>
>> On 10/11/22 03:47, Naresh Solanki wrote:
>>> Add common fan properties bindings to a schema.
>>>
>>> Bindings for fan controllers can reference the common schema for the
>>> fan
>>>
>>> child nodes:
>>>
>>> patternProperties:
>>> "^fan@[0-2]":
>>> type: object
>>> allOf:
>>> - $ref: fan-common.yaml#
>>>
>>> Signed-off-by: Naresh Solanki <[email protected]>
>>> ---
>>> .../devicetree/bindings/hwmon/fan-common.yaml | 80 +++++++++++++++++++
>>> 1 file changed, 80 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
>>> new file mode 100644
>>> index 000000000000..abc8375da646
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
>>> @@ -0,0 +1,80 @@
>>> +# SPDX-License-Identifier: GPL-2.0-only
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Common fan properties
>>> +
>>> +maintainers:
>>> + - Naresh Solanki <[email protected]>
>>> +
>>> +properties:
>>> + max-rpm:
>>> + description:
>>> + Max RPM supported by fan
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> +
>>> + pulse-per-revolution:
>>> + description:
>>> + The number of pulse from fan sensor per revolution.
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> +
>>> + target-rpm:
>>> + description:
>>> + Target RPM the fan should be configured during driver probe.
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> +
>>> + pwm-frequency:
>>> + description:
>>> + PWM frequency for fan.
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> +
>>> + pwm-polarity-inverse:
>>> + description:
>>> + PWM polarity for fan.
>>> + type: boolean
>>> +
>>> + label:
>>> + description:
>>> + Optional fan label
>>> + $ref: /schemas/types.yaml#/definitions/string
>>> +
>>
>> Same question as before:
>>
>> How are additional common bindings, such as min-rpm or fan-divider
>> (also sometimes called fan-prescale) supposed to be handled ?
>> As additions to this schema, or individually in each driver needing/
>> using them ?
>>
>> Thanks,
>> Guenter
On Tue, Oct 11, 2022 at 09:46:08AM -0700, Guenter Roeck wrote:
> On 10/11/22 09:12, Naresh Solanki wrote:
> > Hi Guenter,
> >
> > fan-common is intended for fan properties. i.e., those derived from
> > fan datasheets.
> > For min-rpm, some fans have minimum non zero rpm like 1900rpm below which
> > the fan cannot run.
> >
>
> I would argue the properties are for fan controllers, not for fans.
> Fans don't have or depend on specific pwm frequencies. Fan controllers
> do.
Presumably fan controllers can produce a range of frequencies. If they
need a specific frequency, then why are they programmable? Something
outside the fan controller must have the constraint.
> Fans don't have a configurable pwm polarity. Fan controllers do,
> to match the hardware on a board.
We don't model an inverter, so it's got to go somewhere.
> Fans don't have or rely on
> a target rpm. That is a system property, configured into the
> fan controller. And so on.
Yes, but it is per fan. per fan properties/settings should go in the fan
node IMO.
> If this is for fans, we'll need another set of properties for
> fan controllers. The driver for max6639, being a fan controller,
> would need to implement those properties.
>
> Also, as implemented in the MAX6639, max-rpm is the fan's
> rpm range, not the actual rpm. Your implementation is just
> confusing, including the example in the bindings. Valid values
> should be what the chip accepts, not some random value.
A fan would have some design maximum RPM depending on its mechanical
design and lifetime requirements. A controller would have some maximum
in terms of electrical pulse frequency or register bit sizes (depending
how RPM or pulse counts are exposed to s/w. That should all be implied
from the controller part and not in DT. It's the mechanical limits of
the fan we should be defining here.
> Really, I don't understand where you are going with this.
Certainly it needs more thought for different cases.
Rob
On Tue, Oct 11, 2022 at 5:47 AM Naresh Solanki
<[email protected]> wrote:
>
> Add common fan properties bindings to a schema.
>
> Bindings for fan controllers can reference the common schema for the
> fan
>
> child nodes:
>
> patternProperties:
> "^fan@[0-2]":
> type: object
> allOf:
Don't allOf here.
> - $ref: fan-common.yaml#
>
> Signed-off-by: Naresh Solanki <[email protected]>
> ---
> .../devicetree/bindings/hwmon/fan-common.yaml | 80 +++++++++++++++++++
> 1 file changed, 80 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> new file mode 100644
> index 000000000000..abc8375da646
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> @@ -0,0 +1,80 @@
> +# SPDX-License-Identifier: GPL-2.0-only
Dual license with BSD-2-Clause.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Common fan properties
> +
> +maintainers:
> + - Naresh Solanki <[email protected]>
> +
> +properties:
> + max-rpm:
> + description:
> + Max RPM supported by fan
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pulse-per-revolution:
The already in use property is 'pulses-per-revolution'.
> + description:
> + The number of pulse from fan sensor per revolution.
> + $ref: /schemas/types.yaml#/definitions/uint32
I assume there's a known set of values various fans have?
> +
> + target-rpm:
> + description:
> + Target RPM the fan should be configured during driver probe.
Which driver? I think 'default-rpm' would be a better name.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pwm-frequency:
> + description:
> + PWM frequency for fan.
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + pwm-polarity-inverse:
> + description:
> + PWM polarity for fan.
> + type: boolean
Both of these properties are handled by the PWM binding already. I
think this should use it even though the PWMs are just connected to
the child nodes. There's always the possibility that someone hooks up
a fan controller PWM to something else besides a fan.
> +
> + label:
> + description:
> + Optional fan label
> + $ref: /schemas/types.yaml#/definitions/string
Doesn't a fan need power? 'fan-supply' is already in use, so that could be used.
> +
> +additionalProperties: true
> +
> +examples:
> + - |
Drop the example here as you have it in the max6639 schema.
> +
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan-controller@30 {
> + compatible = "maxim,max6639";
> + reg = <0x30>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + fan@0 {
> + reg = <0>;
> + label = "CPU0_Fan";
> + max-rpm = <32000>;
> + pulse-per-revolution = <2>;
> + target-rpm = <2000>;
> + pwm-frequency = <25000>;
> + };
> +
> + fan@1 {
> + reg = <1>;
> + label = "PCIe0_Fan";
> + max-rpm = <32000>;
> + pulse-per-revolution = <2>;
> + target-rpm = <2000>;
> + pwm-frequency = <25000>;
> + };
> +
> + };
> + };
> +
> +...
>
> base-commit: 0cf46a653bdae56683fece68dc50340f7520e6c4
> --
> 2.37.3
>
Hi Rob, Guenter, Krzysztof,
I want to align with the implementation for the fan dt schema.
Current implementation is intending to use fan-common.yaml only for the purpose
of defining fan property as I felt this is the best way. This is how
other drivers have approached(eg: leds)
With this fan-controller driver will configure the chip based on fan
characteristics accordingly.
target-rpm/default-rpm is included in it to enable driver configure
fan controllers during driver
probe.
Fan datasheets do specify the pwm frequency used to evaluate its
characteristic. That is the reason I've
included pwm-frequency here which fan-controller drivers can use &
initialize pwm frequency accordingly.
I'm ok with other approaches so do provide your perspective.
Regards,
Naresh Solanki
On Wed, 12 Oct 2022 at 00:35, Rob Herring <[email protected]> wrote:
>
> On Tue, Oct 11, 2022 at 5:47 AM Naresh Solanki
> <[email protected]> wrote:
> >
> > Add common fan properties bindings to a schema.
> >
> > Bindings for fan controllers can reference the common schema for the
> > fan
> >
> > child nodes:
> >
> > patternProperties:
> > "^fan@[0-2]":
> > type: object
> > allOf:
>
> Don't allOf here.
>
> > - $ref: fan-common.yaml#
> >
> > Signed-off-by: Naresh Solanki <[email protected]>
> > ---
> > .../devicetree/bindings/hwmon/fan-common.yaml | 80 +++++++++++++++++++
> > 1 file changed, 80 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/fan-common.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/fan-common.yaml b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> > new file mode 100644
> > index 000000000000..abc8375da646
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/fan-common.yaml
> > @@ -0,0 +1,80 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
>
> Dual license with BSD-2-Clause.
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/fan-common.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Common fan properties
> > +
> > +maintainers:
> > + - Naresh Solanki <[email protected]>
> > +
> > +properties:
> > + max-rpm:
> > + description:
> > + Max RPM supported by fan
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + pulse-per-revolution:
>
> The already in use property is 'pulses-per-revolution'.
>
> > + description:
> > + The number of pulse from fan sensor per revolution.
> > + $ref: /schemas/types.yaml#/definitions/uint32
>
> I assume there's a known set of values various fans have?
>
> > +
> > + target-rpm:
> > + description:
> > + Target RPM the fan should be configured during driver probe.
>
> Which driver? I think 'default-rpm' would be a better name.
>
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + pwm-frequency:
> > + description:
> > + PWM frequency for fan.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > +
> > + pwm-polarity-inverse:
> > + description:
> > + PWM polarity for fan.
> > + type: boolean
>
> Both of these properties are handled by the PWM binding already. I
> think this should use it even though the PWMs are just connected to
> the child nodes. There's always the possibility that someone hooks up
> a fan controller PWM to something else besides a fan.
>
> > +
> > + label:
> > + description:
> > + Optional fan label
> > + $ref: /schemas/types.yaml#/definitions/string
>
> Doesn't a fan need power? 'fan-supply' is already in use, so that could be used.
>
> > +
> > +additionalProperties: true
> > +
> > +examples:
> > + - |
>
> Drop the example here as you have it in the max6639 schema.
>
> > +
> > +
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + fan-controller@30 {
> > + compatible = "maxim,max6639";
> > + reg = <0x30>;
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + fan@0 {
> > + reg = <0>;
> > + label = "CPU0_Fan";
> > + max-rpm = <32000>;
> > + pulse-per-revolution = <2>;
> > + target-rpm = <2000>;
> > + pwm-frequency = <25000>;
> > + };
> > +
> > + fan@1 {
> > + reg = <1>;
> > + label = "PCIe0_Fan";
> > + max-rpm = <32000>;
> > + pulse-per-revolution = <2>;
> > + target-rpm = <2000>;
> > + pwm-frequency = <25000>;
> > + };
> > +
> > + };
> > + };
> > +
> > +...
> >
> > base-commit: 0cf46a653bdae56683fece68dc50340f7520e6c4
> > --
> > 2.37.3
> >