Subject: Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems

Il 29/03/22 13:45, Tinghan Shen ha scritto:
> Add optional host top register base for the reg binding description.
>
> Signed-off-by: Wenbin Mei <[email protected]>
> Signed-off-by: Tinghan Shen <[email protected]>
> ---
> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 7032f7adf3ca..6d41bcec900f 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -40,7 +40,8 @@ properties:
> - const: mediatek,mt8183-mmc
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2

it's just maxItems... adding minItems: 1 is not required.

>
> clocks:
> description:


2022-03-31 04:16:17

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v12 2/3] dt-bindings: mmc: mtk-sd: increase reg maxItems

On Tue, Mar 29, 2022 at 7:43 AM AngeloGioacchino Del Regno
<[email protected]> wrote:
>
> Il 29/03/22 13:45, Tinghan Shen ha scritto:
> > Add optional host top register base for the reg binding description.
> >
> > Signed-off-by: Wenbin Mei <[email protected]>
> > Signed-off-by: Tinghan Shen <[email protected]>
> > ---
> > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > index 7032f7adf3ca..6d41bcec900f 100644
> > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> > @@ -40,7 +40,8 @@ properties:
> > - const: mediatek,mt8183-mmc
> >
> > reg:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
>
> it's just maxItems... adding minItems: 1 is not required.

If 1 entry is still valid, then minItems is required. If not, then
it's an ABI break.

Rob