2014-10-15 19:03:49

by Fabian Frédérick

Subject: [PATCH 1/1 net-next] openvswitch: use vport instead of p

All functions used struct vport *vport except
ovs_vport_find_upcall_portid.

This fixes 1 kerneldoc warning

Signed-off-by: Fabian Frederick <[email protected]>
---
net/openvswitch/vport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 53001b0..6015802 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -408,13 +408,13 @@ int ovs_vport_get_upcall_portids(const struct vport *vport,
*
* Returns the portid of the target socket. Must be called with rcu_read_lock.
*/
-u32 ovs_vport_find_upcall_portid(const struct vport *p, struct sk_buff *skb)
+u32 ovs_vport_find_upcall_portid(const struct vport *vport, struct sk_buff *skb)
{
struct vport_portids *ids;
u32 ids_index;
u32 hash;

- ids = rcu_dereference(p->upcall_portids);
+ ids = rcu_dereference(vport->upcall_portids);

if (ids->n_ids == 1 && ids->ids[0] == 0)
return 0;
--
1.9.3

2014-10-16 01:19:35

by Pravin Shelar

Subject: Re: [PATCH 1/1 net-next] openvswitch: use vport instead of p

On Wed, Oct 15, 2014 at 12:03 PM, Fabian Frederick <[email protected]> wrote:
> All functions used struct vport *vport except
> ovs_vport_find_upcall_portid.
>
> This fixes 1 kerneldoc warning
>
> Signed-off-by: Fabian Frederick <[email protected]>


Acked-by: Pravin B Shelar <[email protected]>

Thanks.

> ---
> net/openvswitch/vport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
> index 53001b0..6015802 100644
> --- a/net/openvswitch/vport.c
> +++ b/net/openvswitch/vport.c
> @@ -408,13 +408,13 @@ int ovs_vport_get_upcall_portids(const struct vport *vport,
> *
> * Returns the portid of the target socket. Must be called with rcu_read_lock.
> */
> -u32 ovs_vport_find_upcall_portid(const struct vport *p, struct sk_buff *skb)
> +u32 ovs_vport_find_upcall_portid(const struct vport *vport, struct sk_buff *skb)
> {
> struct vport_portids *ids;
> u32 ids_index;
> u32 hash;
>
> - ids = rcu_dereference(p->upcall_portids);
> + ids = rcu_dereference(vport->upcall_portids);
>
> if (ids->n_ids == 1 && ids->ids[0] == 0)
> return 0;
> --
> 1.9.3
>

2014-10-16 03:26:06

by David Miller

Subject: Re: [PATCH 1/1 net-next] openvswitch: use vport instead of p

From: Fabian Frederick <[email protected]>
Date: Wed, 15 Oct 2014 21:03:41 +0200

> All functions used struct vport *vport except
> ovs_vport_find_upcall_portid.
>
> This fixes 1 kerneldoc warning
>
> Signed-off-by: Fabian Frederick <[email protected]>

Applied.