2022-10-31 13:25:59

by Ajye Huang

[permalink] [raw]
Subject: Re: [PATCH v4 1/2] ASoC: mediatek: dt-bindings: modify machine bindings for two MICs case

Hi Rob Herring,


On Mon, Oct 31, 2022 at 1:26 AM Ajye Huang
<[email protected]> wrote:
>
> +
> + dmic-gpios = <&pio 23 0>;
>
> headset-codec {
> sound-dai = <&rt5682s>;
> --
> 2.25.1
>

I think the modification will be better, I will send v5 again, thanks
@@ -63,14 +70,19 @@ required:

examples:
- |
+ #include <dt-bindings/gpio/gpio.h>

sound: mt8186-sound {
compatible = "mediatek,mt8186-mt6366-rt1019-rt5682s-sound";
mediatek,platform = <&afe>;
pinctrl-names = "aud_clk_mosi_off",
- "aud_clk_mosi_on";
+ "aud_clk_mosi_on",
+ "aud_gpio_dmic_sec";
pinctrl-0 = <&aud_clk_mosi_off>;
pinctrl-1 = <&aud_clk_mosi_on>;
+ pinctrl-2 = <&aud_gpio_dmic_sec>;
+
+ dmic-gpios = <&pio 23 GPIO_ACTIVE_HIGH>;

headset-codec {
sound-dai = <&rt5682s>;