Hi Pierre
On Fri, Dec 16, 2022 at 11:49 PM Ajye Huang
<[email protected]> wrote:
Based on the suggestions you provided in v1,
> Suggested edit:
>
> ASoC: Intel: sof_nau8825: add variant with nau8318 amplifier.
>
> That should be added in the commit message please.
>
The v2 includes:
changes from v1->v2:
* Modify title and add explanations in commit messages .
* Use new topology file "sof-adl-nau8318-nau8825.tplg" instead of
sof-adl-max98360a-nau8825.tplg.
Thanks for your suggestions.
> The v2 includes:
> changes from v1->v2:
> * Modify title and add explanations in commit messages .
> * Use new topology file "sof-adl-nau8318-nau8825.tplg" instead of
> sof-adl-max98360a-nau8825.tplg.
You can add those directly in the patch, below the --- marker, e.g.
Signed-off-by: Ajye Huang <[email protected]>
---
changes from v1->v2:
* Modify title and add explanations in commit messages .
* Use new topology file "sof-adl-nau8318-nau8825.tplg" instead of
sof-adl-max98360a-nau8825.tplg.
sound/soc/intel/boards/Kconfig | 1 +
sound/soc/intel/boards/sof_nau8825.c | 23 +++++++++++++++++++
.../intel/common/soc-acpi-intel-adl-match.c | 12 ++++++++++
3 files changed, 36 insertions(+)
HI Pierre-Louis,
On Sat, Dec 17, 2022 at 12:06 AM Pierre-Louis Bossart
<[email protected]> wrote:
> You can add those directly in the patch, below the --- marker, e.g.
>
>
> Signed-off-by: Ajye Huang <[email protected]>
> ---
>
> changes from v1->v2:
> * Modify title and add explanations in commit messages .
> * Use new topology file "sof-adl-nau8318-nau8825.tplg" instead of
> sof-adl-max98360a-nau8825.tplg.
>
> sound/soc/intel/boards/Kconfig | 1 +
> sound/soc/intel/boards/sof_nau8825.c | 23 +++++++++++++++++++
> .../intel/common/soc-acpi-intel-adl-match.c | 12 ++++++++++
> 3 files changed, 36 insertions(+)
Yes, it is really better, thanks for letting me know.