2023-02-22 20:42:50

by Sean Anderson

[permalink] [raw]
Subject: [PATCH net] net: sunhme: Fix region request

devm_request_region is for I/O regions. Use devm_request_mem_region
instead. This fixes the driver failing to probe since 99df45c9e0a4
("sunhme: fix an IS_ERR() vs NULL check in probe"), which checked the
result.

Fixes: 914d9b2711dd ("sunhme: switch to devres")
Signed-off-by: Sean Anderson <[email protected]>
---

drivers/net/ethernet/sun/sunhme.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
index 1c16548415cd..b0c7ab74a82e 100644
--- a/drivers/net/ethernet/sun/sunhme.c
+++ b/drivers/net/ethernet/sun/sunhme.c
@@ -2894,8 +2894,10 @@ static int happy_meal_pci_probe(struct pci_dev *pdev,
goto err_out_clear_quattro;
}

- hpreg_res = devm_request_region(&pdev->dev, pci_resource_start(pdev, 0),
- pci_resource_len(pdev, 0), DRV_NAME);
+ hpreg_res = devm_request_mem_region(&pdev->dev,
+ pci_resource_start(pdev, 0),
+ pci_resource_len(pdev, 0),
+ DRV_NAME);
if (!hpreg_res) {
err = -EBUSY;
dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");
--
2.37.1



2023-02-23 08:06:33

by Pavan Chebbi

[permalink] [raw]
Subject: Re: [PATCH net] net: sunhme: Fix region request

On Thu, Feb 23, 2023 at 2:12 AM Sean Anderson <[email protected]> wrote:
>
> devm_request_region is for I/O regions. Use devm_request_mem_region
> instead. This fixes the driver failing to probe since 99df45c9e0a4
> ("sunhme: fix an IS_ERR() vs NULL check in probe"), which checked the
> result.
>
> Fixes: 914d9b2711dd ("sunhme: switch to devres")
> Signed-off-by: Sean Anderson <[email protected]>
> ---
>
Looks OK to me.
Reviewed-by: Pavan Chebbi <[email protected]>


> drivers/net/ethernet/sun/sunhme.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index 1c16548415cd..b0c7ab74a82e 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -2894,8 +2894,10 @@ static int happy_meal_pci_probe(struct pci_dev *pdev,
> goto err_out_clear_quattro;
> }
>
> - hpreg_res = devm_request_region(&pdev->dev, pci_resource_start(pdev, 0),
> - pci_resource_len(pdev, 0), DRV_NAME);
> + hpreg_res = devm_request_mem_region(&pdev->dev,
> + pci_resource_start(pdev, 0),
> + pci_resource_len(pdev, 0),
> + DRV_NAME);
> if (!hpreg_res) {
> err = -EBUSY;
> dev_err(&pdev->dev, "Cannot obtain PCI resources, aborting.\n");
> --
> 2.37.1
>

Attachments:
smime.p7s (4.11 kB)
S/MIME Cryptographic Signature

2023-02-24 03:03:41

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net] net: sunhme: Fix region request

On Wed, 22 Feb 2023 15:42:41 -0500 Sean Anderson wrote:
> devm_request_region is for I/O regions. Use devm_request_mem_region
> instead. This fixes the driver failing to probe since 99df45c9e0a4
> ("sunhme: fix an IS_ERR() vs NULL check in probe"), which checked the
> result.
>
> Fixes: 914d9b2711dd ("sunhme: switch to devres")
> Signed-off-by: Sean Anderson <[email protected]>

Applied, thanks!