2015-05-18 09:31:20

by Valentin Rothberg

[permalink] [raw]
Subject: ARM: STM32: undefined ARMV7M_SYSTICK

Hi Maxime,

your commit 9b799b78372c ("ARM: Add STM32 family machine") is in
today's linux-next tree (i.e., next-20150518) adding the following
Kconfig select:

+config ARCH_STM32
[...]
+ select ARMV7M_SYSTICK

ARMV7M_SYSTICK is not defined in Kconfig, so that the select turns out
to be a NOP. Is there a patch queued somewhere that adds this Kconfig
option?

I detected this issue with scripts/checkkconfigsymbols.py by diffing
yesterday's and today's linux-next tree. You can also use the script
to check specific commits for Kconfig related issues.

Kind regards,
Valentin


2015-05-18 10:16:31

by Maxime Coquelin

[permalink] [raw]
Subject: Re: ARM: STM32: undefined ARMV7M_SYSTICK

Hi Valentin,

2015-05-18 11:30 GMT+02:00 Valentin Rothberg <[email protected]>:
> Hi Maxime,
>
> your commit 9b799b78372c ("ARM: Add STM32 family machine") is in
> today's linux-next tree (i.e., next-20150518) adding the following
> Kconfig select:
>
> +config ARCH_STM32
> [...]
> + select ARMV7M_SYSTICK
>
> ARMV7M_SYSTICK is not defined in Kconfig, so that the select turns out
> to be a NOP. Is there a patch queued somewhere that adds this Kconfig
> option?

Yes, this Kconfig option is added by another patch[0].
I expect this patch to be taken by clocksource maintainers for v4.2.

>
> I detected this issue with scripts/checkkconfigsymbols.py by diffing
> yesterday's and today's linux-next tree. You can also use the script
> to check specific commits for Kconfig related issues.
Ok. Thanks for the hint.

Kind regards,
Maxime

>
> Kind regards,
> Valentin

[0]: https://stintbugzilla.st.com/show_bug.cgi?id=72732

2015-05-18 10:17:51

by Maxime Coquelin

[permalink] [raw]
Subject: Re: ARM: STM32: undefined ARMV7M_SYSTICK

2015-05-18 12:16 GMT+02:00 Maxime Coquelin <[email protected]>:
> Hi Valentin,
>
> 2015-05-18 11:30 GMT+02:00 Valentin Rothberg <[email protected]>:
>> Hi Maxime,
>>
>> your commit 9b799b78372c ("ARM: Add STM32 family machine") is in
>> today's linux-next tree (i.e., next-20150518) adding the following
>> Kconfig select:
>>
>> +config ARCH_STM32
>> [...]
>> + select ARMV7M_SYSTICK
>>
>> ARMV7M_SYSTICK is not defined in Kconfig, so that the select turns out
>> to be a NOP. Is there a patch queued somewhere that adds this Kconfig
>> option?
>
> Yes, this Kconfig option is added by another patch[0].
> I expect this patch to be taken by clocksource maintainers for v4.2.
>
>>
>> I detected this issue with scripts/checkkconfigsymbols.py by diffing
>> yesterday's and today's linux-next tree. You can also use the script
>> to check specific commits for Kconfig related issues.
> Ok. Thanks for the hint.
>
> Kind regards,
> Maxime
>
>>
>> Kind regards,
>> Valentin
>

Sorry, with correct link:

https://lkml.org/lkml/2015/5/9/47

Kind regards,
Maxime