2020-10-18 15:55:17

by Vaishnav M A

Subject: [PATCH v3] iio: proximity: vl53l0x-i2c add i2c_device_id

Add i2c_device_id table for the vl53l0x-i2c driver,
helps in device instantiation using i2c_new_client_device
or from userspace in cases where device-tree based description
is not possible now (Example: device on a gbphy i2c adapter
created by greybus)

Signed-off-by: Vaishnav M A <[email protected]>
---
v3:
-modify commit message for readability
as suggested by Jonathan Cameron
v2:
-fix commit message
drivers/iio/proximity/vl53l0x-i2c.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/iio/proximity/vl53l0x-i2c.c b/drivers/iio/proximity/vl53l0x-i2c.c
index 5fbda9475ba9..7c29d4cae24a 100644
--- a/drivers/iio/proximity/vl53l0x-i2c.c
+++ b/drivers/iio/proximity/vl53l0x-i2c.c
@@ -143,6 +143,12 @@ static int vl53l0x_probe(struct i2c_client *client)
return devm_iio_device_register(&client->dev, indio_dev);
}

+static const struct i2c_device_id vl53l0x_id[] = {
+ { "vl53l0x", 0},
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, vl53l0x_id);
+
static const struct of_device_id st_vl53l0x_dt_match[] = {
{ .compatible = "st,vl53l0x", },
{ }
@@ -155,6 +161,7 @@ static struct i2c_driver vl53l0x_driver = {
.of_match_table = st_vl53l0x_dt_match,
},
.probe_new = vl53l0x_probe,
+ .id_table = vl53l0x_id,
};
module_i2c_driver(vl53l0x_driver);

--
2.25.1

2020-10-18 19:08:12

by Andy Shevchenko

Subject: Re: [PATCH v3] iio: proximity: vl53l0x-i2c add i2c_device_id

On Sun, Oct 18, 2020 at 6:53 PM Vaishnav M A <[email protected]> wrote:
>
> Add i2c_device_id table for the vl53l0x-i2c driver,
> helps in device instantiation using i2c_new_client_device
> or from userspace in cases where device-tree based description
> is not possible now (Example: device on a gbphy i2c adapter
> created by greybus)

Same comments as per v1.

--
With Best Regards,
Andy Shevchenko

2020-10-18 20:10:44

by Vaishnav M A

Subject: Re: [PATCH v3] iio: proximity: vl53l0x-i2c add i2c_device_id

On Mon, Oct 19, 2020 at 12:00 AM Andy Shevchenko
<[email protected]> wrote:
>
> On Sun, Oct 18, 2020 at 6:53 PM Vaishnav M A <[email protected]> wrote:
> >
> > Add i2c_device_id table for the vl53l0x-i2c driver,
> > helps in device instantiation using i2c_new_client_device
> > or from userspace in cases where device-tree based description
> > is not possible now (Example: device on a gbphy i2c adapter
> > created by greybus)
>
> Same comments as per v1.
>
> --
> With Best Regards,
> Andy Shevchenko

Thank you Andy for your review, I have updated v4 patch with your
suggestions : https://lore.kernel.org/patchwork/patch/1322218/

Thanks,
Vaishnav