2021-08-02 14:41:12

by Shakeel Butt

[permalink] [raw]
Subject: Re: [PATCH v2] mm/memcg: Fix incorrect flushing of lruvec data in obj_stock

On Mon, Aug 2, 2021 at 7:38 AM Waiman Long <[email protected]> wrote:
>
> When mod_objcg_state() is called with a pgdat that is different from
> that in the obj_stock, the old lruvec data cached in obj_stock are
> flushed out. Unfortunately, they were flushed to the new pgdat and
> so the data go to the wrong node. This will screw up the slab data
> reported in /sys/devices/system/node/node*/meminfo.
>
> Fix that by flushing the data to the cached pgdat instead.
>
> Fixes: 68ac5b3c8db2 ("mm/memcg: cache vmstat data in percpu memcg_stock_pcp")
> Signed-off-by: Waiman Long <[email protected]>
> Acked-by: Michal Hocko <[email protected]>

Reviewed-by: Shakeel Butt <[email protected]>