2023-06-03 07:40:34

by Miaohe Lin

Subject: [PATCH] memcg: use helper macro FLUSH_TIME

Use helper macro FLUSH_TIME to indicate the flush time to improve the
readability a bit. No functional change intended.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/memcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index d8569594239c..f204c9f2e69c 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -5397,7 +5397,7 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css)

if (unlikely(mem_cgroup_is_root(memcg)))
queue_delayed_work(system_unbound_wq, &stats_flush_dwork,
- 2UL*HZ);
+ FLUSH_TIME);
lru_gen_online_memcg(memcg);
return 0;
offline_kmem:
--
2.27.0

2023-06-03 08:04:49

by Shakeel Butt

Subject: Re: [PATCH] memcg: use helper macro FLUSH_TIME

On Sat, Jun 3, 2023 at 12:21 AM Miaohe Lin <[email protected]> wrote:
>
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Acked-by: Shakeel Butt <[email protected]>

2023-06-03 11:56:44

by Muchun Song

Subject: Re: [PATCH] memcg: use helper macro FLUSH_TIME

> On Jun 3, 2023, at 15:21, Miaohe Lin <[email protected]> wrote:
>
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Muchun Song <[email protected]>

Thanks

2023-06-05 11:41:40

by David Hildenbrand

Subject: Re: [PATCH] memcg: use helper macro FLUSH_TIME

On 03.06.23 09:21, Miaohe Lin wrote:
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> mm/memcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index d8569594239c..f204c9f2e69c 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -5397,7 +5397,7 @@ static int mem_cgroup_css_online(struct cgroup_subsys_state *css)
>
> if (unlikely(mem_cgroup_is_root(memcg)))
> queue_delayed_work(system_unbound_wq, &stats_flush_dwork,
> - 2UL*HZ);
> + FLUSH_TIME);
> lru_gen_online_memcg(memcg);
> return 0;
> offline_kmem:

Reviewed-by: David Hildenbrand <[email protected]>

--
Cheers,

David / dhildenb

2023-06-06 01:00:51

by Roman Gushchin

Subject: Re: [PATCH] memcg: use helper macro FLUSH_TIME

On Sat, Jun 03, 2023 at 03:21:16PM +0800, Miaohe Lin wrote:
> Use helper macro FLUSH_TIME to indicate the flush time to improve the
> readability a bit. No functional change intended.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Acked-by: Roman Gushchin <[email protected]>

Thanks!