2021-04-01 03:06:54

by Shakeel Butt

[permalink] [raw]
Subject: Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg

On Wed, Mar 31, 2021 at 8:02 PM Muchun Song <[email protected]> wrote:
>
> Christian Borntraeger reported a warning about "percpu ref
> (obj_cgroup_release) <= 0 (-1) after switching to atomic".
> Because we forgot to obtain the reference to the objcg and
> wrongly obtain the reference of memcg.
>
> Reported-by: Christian Borntraeger <[email protected]>
> Signed-off-by: Muchun Song <[email protected]>

Looks good to me.

Reviewed-by: Shakeel Butt <[email protected]>