2021-10-11 01:37:29

by Tiezhu Yang

Subject: [PATCH bpf-next v2 0/2] bpf, mips: Do some small changes

This patchset is based on bpf-next tree:
https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git

v2:
-- Update patch #2 to only fix the comment,
suggested by Johan Almbladh, thank you.

Tiezhu Yang (2):
bpf, mips: Clean up config options about JIT
bpf, mips: Fix comment on tail call count limiting

arch/mips/Kconfig | 9 ---------
arch/mips/net/Makefile | 6 +++---
arch/mips/net/bpf_jit_comp32.c | 2 +-
3 files changed, 4 insertions(+), 13 deletions(-)

--
2.1.0

2021-10-11 01:37:29

by Tiezhu Yang

Subject: [PATCH bpf-next v2 2/2] bpf, mips: Fix comment on tail call count limiting

In emit_tail_call() of bpf_jit_comp32.c, "blez t2" (t2 <= 0) is
not consistent with the comment "t2 < 0", update the comment to
keep consistency.

Signed-off-by: Tiezhu Yang <[email protected]>
---
arch/mips/net/bpf_jit_comp32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/net/bpf_jit_comp32.c b/arch/mips/net/bpf_jit_comp32.c
index 9d7041a..bd996ed 100644
--- a/arch/mips/net/bpf_jit_comp32.c
+++ b/arch/mips/net/bpf_jit_comp32.c
@@ -1315,7 +1315,7 @@ static int emit_tail_call(struct jit_context *ctx)
/* if (TCC-- <= 0) goto out */
emit(ctx, lw, t2, ctx->stack_size, MIPS_R_SP); /* t2 = *(SP + size) */
emit_load_delay(ctx); /* Load delay slot */
- emit(ctx, blez, t2, get_offset(ctx, 1)); /* PC += off(1) if t2 < 0 */
+ emit(ctx, blez, t2, get_offset(ctx, 1)); /* PC += off(1) if t2 <= 0 */
emit(ctx, addiu, t2, t2, -1); /* t2-- (delay slot) */
emit(ctx, sw, t2, ctx->stack_size, MIPS_R_SP); /* *(SP + size) = t2 */

--
2.1.0

2021-10-11 12:09:00

by Johan Almbladh

Subject: Re: [PATCH bpf-next v2 2/2] bpf, mips: Fix comment on tail call count limiting

On Mon, Oct 11, 2021 at 3:19 AM Tiezhu Yang <[email protected]> wrote:
>
> In emit_tail_call() of bpf_jit_comp32.c, "blez t2" (t2 <= 0) is
> not consistent with the comment "t2 < 0", update the comment to
> keep consistency.
>
> Signed-off-by: Tiezhu Yang <[email protected]>

Acked-by: Johan Almbladh <[email protected]>

> ---
> arch/mips/net/bpf_jit_comp32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/net/bpf_jit_comp32.c b/arch/mips/net/bpf_jit_comp32.c
> index 9d7041a..bd996ed 100644
> --- a/arch/mips/net/bpf_jit_comp32.c
> +++ b/arch/mips/net/bpf_jit_comp32.c
> @@ -1315,7 +1315,7 @@ static int emit_tail_call(struct jit_context *ctx)
> /* if (TCC-- <= 0) goto out */
> emit(ctx, lw, t2, ctx->stack_size, MIPS_R_SP); /* t2 = *(SP + size) */
> emit_load_delay(ctx); /* Load delay slot */
> - emit(ctx, blez, t2, get_offset(ctx, 1)); /* PC += off(1) if t2 < 0 */
> + emit(ctx, blez, t2, get_offset(ctx, 1)); /* PC += off(1) if t2 <= 0 */
> emit(ctx, addiu, t2, t2, -1); /* t2-- (delay slot) */
> emit(ctx, sw, t2, ctx->stack_size, MIPS_R_SP); /* *(SP + size) = t2 */
>
> --
> 2.1.0
>

2021-10-11 16:28:08

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next v2 0/2] bpf, mips: Do some small changes

Hello:

This series was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <[email protected]>:

On Mon, 11 Oct 2021 09:19:08 +0800 you wrote:
> This patchset is based on bpf-next tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git
>
> v2:
> -- Update patch #2 to only fix the comment,
> suggested by Johan Almbladh, thank you.
>
> [...]

Here is the summary with links:
- [bpf-next,v2,1/2] bpf, mips: Clean up config options about JIT
https://git.kernel.org/bpf/bpf-next/c/307d149d9435
- [bpf-next,v2,2/2] bpf, mips: Fix comment on tail call count limiting
https://git.kernel.org/bpf/bpf-next/c/431bfb9ee3e2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html