2021-01-06 09:00:44

by levi.yun

Subject: [PATCH RESEND] irq: export irq_check_status_bit symbol

Because of the missing export symbol for irq_chekc_status_bit,
Building arm_spe_pmu.ko is a failure on the modpost step.

Below is an error message I saw:
ERROR:modpost: "irq_check_status_bit" [drivers/perf/arm_spe_pmu.ko] undefined!
make[4]: *** [scripts/Makefile.modpost:111: Module.symvers] Error 1
make[4]: *** Deleting file 'Module.symvers'
make[3]: *** [Makefile:1396: modules] Error 2
make[2]: *** [debian/rules:7: build-arch] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
make[1]: *** [scripts/Makefile.package:83: bindeb-pkg] Error 2

Signed-off-by: Levi Yun <[email protected]>
---
kernel/irq/manage.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index ab8567f32501..dec3f73e8db9 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2859,3 +2859,4 @@ bool irq_check_status_bit(unsigned int irq,
unsigned int bitmask)
rcu_read_unlock();
return res;
}
+EXPORT_SYMBOL_GPL(irq_check_status_bit);
--
2.27.0

2021-01-22 04:10:30

by Brooke Basile

Subject: Re: [PATCH RESEND] irq: export irq_check_status_bit symbol

On 1/5/21 10:57 PM, Yun Levi wrote:
> Because of the missing export symbol for irq_chekc_status_bit,
> Building arm_spe_pmu.ko is a failure on the modpost step.
>
> Below is an error message I saw:
> ERROR:modpost: "irq_check_status_bit" [drivers/perf/arm_spe_pmu.ko] undefined!
> make[4]: *** [scripts/Makefile.modpost:111: Module.symvers] Error 1
> make[4]: *** Deleting file 'Module.symvers'
> make[3]: *** [Makefile:1396: modules] Error 2
> make[2]: *** [debian/rules:7: build-arch] Error 2
> dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
> make[1]: *** [scripts/Makefile.package:83: bindeb-pkg] Error 2
>
> Signed-off-by: Levi Yun <[email protected]>
> ---
> kernel/irq/manage.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
> index ab8567f32501..dec3f73e8db9 100644
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2859,3 +2859,4 @@ bool irq_check_status_bit(unsigned int irq,
> unsigned int bitmask)
> rcu_read_unlock();
> return res;
> }
> +EXPORT_SYMBOL_GPL(irq_check_status_bit);
> --
> 2.27.0
>
>

Hi,

I ran into this issue while compiling 5.11-rc4 for my RPi 4B. Applying
this patch fixed the breakage.

Thanks for the fix!

Tested-by: Brooke Basile <[email protected]>

Best,
Brooke Basile