2023-09-12 06:06:50

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH v1 1/5] perf parse-events: Remove unused header files

On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <[email protected]> wrote:
>
> The fnmatch header is now used in the PMU matching logic in pmu.c.
>
> Signed-off-by: Ian Rogers <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung

> ---
> tools/perf/util/parse-events.y | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index 21bfe7e0d944..ef03728b7ea3 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -9,11 +9,8 @@
> #define YYDEBUG 1
>
> #include <errno.h>
> -#include <fnmatch.h>
> -#include <stdio.h>
> #include <linux/compiler.h>
> #include <linux/types.h>
> -#include <linux/zalloc.h>
> #include "pmu.h"
> #include "pmus.h"
> #include "evsel.h"
> --
> 2.42.0.283.g2d96d420d3-goog
>


2023-09-12 20:50:45

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH v1 1/5] perf parse-events: Remove unused header files

Em Mon, Sep 11, 2023 at 10:58:18PM -0700, Namhyung Kim escreveu:
> On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <[email protected]> wrote:
> >
> > The fnmatch header is now used in the PMU matching logic in pmu.c.
> >
> > Signed-off-by: Ian Rogers <[email protected]>
>
> Acked-by: Namhyung Kim <[email protected]>



Thanks, applied the series.

- Arnaldo


> Thanks,
> Namhyung
>
> > ---
> > tools/perf/util/parse-events.y | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> > index 21bfe7e0d944..ef03728b7ea3 100644
> > --- a/tools/perf/util/parse-events.y
> > +++ b/tools/perf/util/parse-events.y
> > @@ -9,11 +9,8 @@
> > #define YYDEBUG 1
> >
> > #include <errno.h>
> > -#include <fnmatch.h>
> > -#include <stdio.h>
> > #include <linux/compiler.h>
> > #include <linux/types.h>
> > -#include <linux/zalloc.h>
> > #include "pmu.h"
> > #include "pmus.h"
> > #include "evsel.h"
> > --
> > 2.42.0.283.g2d96d420d3-goog
> >

--

- Arnaldo