2023-09-28 08:38:01

by Adrian Hunter

Subject: [PATCH] perf intel-pt: Fix async branch flags

Ensure PERF_IP_FLAG_ASYNC is set always for asynchronous branches (i.e.
interrupts etc).

Fixes: 90e457f7be08 ("perf tools: Add Intel PT support")
Cc: [email protected]
Signed-off-by: Adrian Hunter <[email protected]>
---
tools/perf/util/intel-pt.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
index dbf0bc71a63b..f38893e0b036 100644
--- a/tools/perf/util/intel-pt.c
+++ b/tools/perf/util/intel-pt.c
@@ -1512,9 +1512,11 @@ static void intel_pt_sample_flags(struct intel_pt_queue *ptq)
} else if (ptq->state->flags & INTEL_PT_ASYNC) {
if (!ptq->state->to_ip)
ptq->flags = PERF_IP_FLAG_BRANCH |
+ PERF_IP_FLAG_ASYNC |
PERF_IP_FLAG_TRACE_END;
else if (ptq->state->from_nr && !ptq->state->to_nr)
ptq->flags = PERF_IP_FLAG_BRANCH | PERF_IP_FLAG_CALL |
+ PERF_IP_FLAG_ASYNC |
PERF_IP_FLAG_VMEXIT;
else
ptq->flags = PERF_IP_FLAG_BRANCH | PERF_IP_FLAG_CALL |
--
2.34.1

2023-09-30 06:48:03

by Namhyung Kim

Subject: Re: [PATCH] perf intel-pt: Fix async branch flags

On Thu, Sep 28, 2023 at 12:30 AM Adrian Hunter <[email protected]> wrote:
>
> Ensure PERF_IP_FLAG_ASYNC is set always for asynchronous branches (i.e.
> interrupts etc).
>
> Fixes: 90e457f7be08 ("perf tools: Add Intel PT support")
> Cc: [email protected]
> Signed-off-by: Adrian Hunter <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


> ---
> tools/perf/util/intel-pt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
> index dbf0bc71a63b..f38893e0b036 100644
> --- a/tools/perf/util/intel-pt.c
> +++ b/tools/perf/util/intel-pt.c
> @@ -1512,9 +1512,11 @@ static void intel_pt_sample_flags(struct intel_pt_queue *ptq)
> } else if (ptq->state->flags & INTEL_PT_ASYNC) {
> if (!ptq->state->to_ip)
> ptq->flags = PERF_IP_FLAG_BRANCH |
> + PERF_IP_FLAG_ASYNC |
> PERF_IP_FLAG_TRACE_END;
> else if (ptq->state->from_nr && !ptq->state->to_nr)
> ptq->flags = PERF_IP_FLAG_BRANCH | PERF_IP_FLAG_CALL |
> + PERF_IP_FLAG_ASYNC |
> PERF_IP_FLAG_VMEXIT;
> else
> ptq->flags = PERF_IP_FLAG_BRANCH | PERF_IP_FLAG_CALL |
> --
> 2.34.1
>
>

2023-10-03 04:12:12

by Namhyung Kim

Subject: Re: [PATCH] perf intel-pt: Fix async branch flags

On Fri, Sep 29, 2023 at 11:40 PM Namhyung Kim <[email protected]> wrote:
>
> On Thu, Sep 28, 2023 at 12:30 AM Adrian Hunter <[email protected]> wrote:
> >
> > Ensure PERF_IP_FLAG_ASYNC is set always for asynchronous branches (i.e.
> > interrupts etc).
> >
> > Fixes: 90e457f7be08 ("perf tools: Add Intel PT support")
> > Cc: [email protected]
> > Signed-off-by: Adrian Hunter <[email protected]>
>
> Acked-by: Namhyung Kim <[email protected]>

Applied to perf-tools-next, thanks!