From: Arnaldo Carvalho de Melo <[email protected]>
This is a longstanding to do list entry: we need a way to see that a
sample took place while in idle state, as the current way to do it is
to infer that by the name of the functions that in such state have
more samples, IOW: a hack.
Maybe we can do flip a bit in samples that take place inside the
enter/exit idle section in do_idle()?
But till then, add one more :-\
Cc: Adrian Hunter <[email protected]>
cc: Fr?d?ric Weisbecker <[email protected]>
Cc: Ian Rogers <[email protected]>
Cc: Ingo Molnar <[email protected]>,
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/util/symbol.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 5b54d2639df4740e..3c7f483bf85bbdaf 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -718,6 +718,7 @@ static bool symbol__is_idle(const char *name)
"cpu_startup_entry",
"idle_cpu",
"intel_idle",
+ "intel_idle_ibrs",
"default_idle",
"native_safe_halt",
"enter_idle",
--
2.41.0
Hi Arnaldo,
On Thu, Oct 5, 2023 at 6:29 AM Arnaldo Carvalho de Melo <[email protected]> wrote:
>
> From: Arnaldo Carvalho de Melo <[email protected]>
>
> This is a longstanding to do list entry: we need a way to see that a
> sample took place while in idle state, as the current way to do it is
> to infer that by the name of the functions that in such state have
> more samples, IOW: a hack.
>
> Maybe we can do flip a bit in samples that take place inside the
> enter/exit idle section in do_idle()?
>
> But till then, add one more :-\
>
> Cc: Adrian Hunter <[email protected]>
> cc: Frédéric Weisbecker <[email protected]>
> Cc: Ian Rogers <[email protected]>
> Cc: Ingo Molnar <[email protected]>,
> Cc: Jiri Olsa <[email protected]>
> Cc: Namhyung Kim <[email protected]>
> Cc: Peter Zijlstra <[email protected]>
> Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Acked-by: Namhyung Kim <[email protected]>
Thanks,
Namhyung
> ---
> tools/perf/util/symbol.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index 5b54d2639df4740e..3c7f483bf85bbdaf 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -718,6 +718,7 @@ static bool symbol__is_idle(const char *name)
> "cpu_startup_entry",
> "idle_cpu",
> "intel_idle",
> + "intel_idle_ibrs",
> "default_idle",
> "native_safe_halt",
> "enter_idle",
> --
> 2.41.0
>
On Thu, Oct 5, 2023 at 10:16 PM Namhyung Kim <[email protected]> wrote:
>
> Hi Arnaldo,
>
> On Thu, Oct 5, 2023 at 6:29 AM Arnaldo Carvalho de Melo <[email protected]> wrote:
> >
> > From: Arnaldo Carvalho de Melo <[email protected]>
> >
> > This is a longstanding to do list entry: we need a way to see that a
> > sample took place while in idle state, as the current way to do it is
> > to infer that by the name of the functions that in such state have
> > more samples, IOW: a hack.
> >
> > Maybe we can do flip a bit in samples that take place inside the
> > enter/exit idle section in do_idle()?
> >
> > But till then, add one more :-\
> >
> > Cc: Adrian Hunter <[email protected]>
> > cc: Frédéric Weisbecker <[email protected]>
> > Cc: Ian Rogers <[email protected]>
> > Cc: Ingo Molnar <[email protected]>,
> > Cc: Jiri Olsa <[email protected]>
> > Cc: Namhyung Kim <[email protected]>
> > Cc: Peter Zijlstra <[email protected]>
> > Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
>
> Acked-by: Namhyung Kim <[email protected]>
Applied to perf-tools-next, thanks!