2023-09-12 06:01:54

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH v1 2/5] perf parse-events: Make YYDEBUG dependent on doing a debug build

On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <[email protected]> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> parse-events-bison.c. These shouldn't be generated when debugging
> isn't enabled.
>
> Signed-off-by: Ian Rogers <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


> ---
> tools/perf/util/parse-events.y | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index ef03728b7ea3..786393106ae6 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -6,7 +6,9 @@
>
> %{
>
> +#ifndef NDEBUG
> #define YYDEBUG 1
> +#endif
>
> #include <errno.h>
> #include <linux/compiler.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>