2023-09-12 15:57:39

by Namhyung Kim

[permalink] [raw]
Subject: Re: [PATCH v1 5/5] perf bpf-filter: Add YYDEBUG

On Mon, Sep 11, 2023 at 10:06 AM Ian Rogers <[email protected]> wrote:
>
> YYDEBUG enables line numbers and other error helpers in the generated
> bpf-filter-bison.c. Conditionally enabled only for debug builds.
>
> Signed-off-by: Ian Rogers <[email protected]>

Acked-by: Namhyung Kim <[email protected]>

Thanks,
Namhyung


> ---
> tools/perf/util/bpf-filter.y | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/perf/util/bpf-filter.y b/tools/perf/util/bpf-filter.y
> index 5dfa948fc986..0e4d6de3c2ad 100644
> --- a/tools/perf/util/bpf-filter.y
> +++ b/tools/perf/util/bpf-filter.y
> @@ -3,6 +3,10 @@
>
> %{
>
> +#ifndef NDEBUG
> +#define YYDEBUG 1
> +#endif
> +
> #include <stdio.h>
> #include <string.h>
> #include <linux/compiler.h>
> --
> 2.42.0.283.g2d96d420d3-goog
>